Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: components/history/core/browser/history_backend.h

Issue 1180403005: Use URL without fragment when query recent redirect list for favicons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and answered nit. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_backend.h
diff --git a/components/history/core/browser/history_backend.h b/components/history/core/browser/history_backend.h
index 76d4b50b0b0c64248453f8b46bd3a76228dcc150..aa2ce2f623ad0587d8542a007b7e481e0c6c7be0 100644
--- a/components/history/core/browser/history_backend.h
+++ b/components/history/core/browser/history_backend.h
@@ -484,6 +484,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
SetFaviconMappingsForPageAndRedirects);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
+ SetFaviconMappingsForPageAndRedirectsWithFragment);
+ FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
SetFaviconMappingsForPageDuplicates);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, SetFaviconsDeleteBitmaps);
FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, SetFaviconsReplaceBitmapData);
@@ -693,8 +695,16 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
favicon_base::IconType icon_type,
const std::vector<favicon_base::FaviconID>& icon_ids);
+ // Maps the favicon ids in |icon_ids| to URLs in |page_urls| for |icon_type|.
+ // Returns true if the function changed at least one of the |page_urls|
+ // mappings.
+ bool SetFaviconMappingsForPages(
+ const std::vector<GURL>& page_urls,
+ favicon_base::IconType icon_type,
+ const std::vector<favicon_base::FaviconID>& icon_ids);
+
// Maps the favicon ids in |icon_ids| to |page_url| for |icon_type|.
- // Returns true if the function changed some of |page_url|'s mappings.
+ // Returns true if the function changed at least one of |page_url|'s mappings.
bool SetFaviconMappingsForPage(
const GURL& page_url,
favicon_base::IconType icon_type,
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698