Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: components/history/core/browser/history_backend.h

Issue 1180403005: Use URL without fragment when query recent redirect list for favicons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor clean-up (2) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_ 5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_
6 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_ 6 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 675 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 686
687 // Maps the favicon ids in |icon_ids| to |page_url| (and all redirects) 687 // Maps the favicon ids in |icon_ids| to |page_url| (and all redirects)
688 // for |icon_type|. 688 // for |icon_type|.
689 // Returns true if the mappings for the page or any of its redirects were 689 // Returns true if the mappings for the page or any of its redirects were
690 // changed. 690 // changed.
691 bool SetFaviconMappingsForPageAndRedirects( 691 bool SetFaviconMappingsForPageAndRedirects(
692 const GURL& page_url, 692 const GURL& page_url,
693 favicon_base::IconType icon_type, 693 favicon_base::IconType icon_type,
694 const std::vector<favicon_base::FaviconID>& icon_ids); 694 const std::vector<favicon_base::FaviconID>& icon_ids);
695 695
696 // Maps the favicon ids in |icon_ids| to URLs in |page_urls| for |icon_type|.
697 // Returns true if the function changed some of the |page_urls| mappings.
698 bool SetFaviconMappingsForPages(
699 const std::vector<GURL>& page_urls,
700 favicon_base::IconType icon_type,
701 const std::vector<favicon_base::FaviconID>& icon_ids);
702
696 // Maps the favicon ids in |icon_ids| to |page_url| for |icon_type|. 703 // Maps the favicon ids in |icon_ids| to |page_url| for |icon_type|.
697 // Returns true if the function changed some of |page_url|'s mappings. 704 // Returns true if the function changed some of |page_url|'s mappings.
698 bool SetFaviconMappingsForPage( 705 bool SetFaviconMappingsForPage(
699 const GURL& page_url, 706 const GURL& page_url,
700 favicon_base::IconType icon_type, 707 favicon_base::IconType icon_type,
701 const std::vector<favicon_base::FaviconID>& icon_ids); 708 const std::vector<favicon_base::FaviconID>& icon_ids);
702 709
703 // Returns all the page URLs in the redirect chain for |page_url|. If there 710 // Returns all the page URLs in the redirect chain for |page_url|. If there
704 // are no known redirects for |page_url|, returns a vector with |page_url|. 711 // are no known redirects for |page_url|, returns a vector with |page_url|.
705 void GetCachedRecentRedirects(const GURL& page_url, 712 void GetCachedRecentRedirects(const GURL& page_url,
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
834 841
835 // List of observers 842 // List of observers
836 base::ObserverList<HistoryBackendObserver> observers_; 843 base::ObserverList<HistoryBackendObserver> observers_;
837 844
838 DISALLOW_COPY_AND_ASSIGN(HistoryBackend); 845 DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
839 }; 846 };
840 847
841 } // namespace history 848 } // namespace history
842 849
843 #endif // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_ 850 #endif // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_
OLDNEW
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | components/history/core/browser/history_backend.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698