Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: components/history/core/browser/history_backend.h

Issue 1180403005: Use URL without fragment when query recent redirect list for favicons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor update. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_ 5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_
6 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_ 6 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 AddPageVisitFiresNotificationWithCorrectDetails); 477 AddPageVisitFiresNotificationWithCorrectDetails);
478 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddPageArgsSource); 478 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddPageArgsSource);
479 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddVisitsSource); 479 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddVisitsSource);
480 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, GetMostRecentVisits); 480 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, GetMostRecentVisits);
481 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, RemoveVisitsSource); 481 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, RemoveVisitsSource);
482 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, RemoveVisitsTransitions); 482 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, RemoveVisitsTransitions);
483 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MigrationVisitSource); 483 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MigrationVisitSource);
484 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, 484 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
485 SetFaviconMappingsForPageAndRedirects); 485 SetFaviconMappingsForPageAndRedirects);
486 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, 486 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
487 SetFaviconMappingsForPageAndRedirectsWithFragment);
488 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
487 SetFaviconMappingsForPageDuplicates); 489 SetFaviconMappingsForPageDuplicates);
488 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, SetFaviconsDeleteBitmaps); 490 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, SetFaviconsDeleteBitmaps);
489 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, SetFaviconsReplaceBitmapData); 491 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, SetFaviconsReplaceBitmapData);
490 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, 492 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
491 SetFaviconsSameFaviconURLForTwoPages); 493 SetFaviconsSameFaviconURLForTwoPages);
492 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, 494 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,
493 UpdateFaviconMappingsAndFetchNoChange); 495 UpdateFaviconMappingsAndFetchNoChange);
494 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconPageURLNotInDB); 496 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconPageURLNotInDB);
495 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconPageURLInDB); 497 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconPageURLInDB);
496 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconMaxFaviconsPerPage); 498 FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, MergeFaviconMaxFaviconsPerPage);
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 688
687 // Maps the favicon ids in |icon_ids| to |page_url| (and all redirects) 689 // Maps the favicon ids in |icon_ids| to |page_url| (and all redirects)
688 // for |icon_type|. 690 // for |icon_type|.
689 // Returns true if the mappings for the page or any of its redirects were 691 // Returns true if the mappings for the page or any of its redirects were
690 // changed. 692 // changed.
691 bool SetFaviconMappingsForPageAndRedirects( 693 bool SetFaviconMappingsForPageAndRedirects(
692 const GURL& page_url, 694 const GURL& page_url,
693 favicon_base::IconType icon_type, 695 favicon_base::IconType icon_type,
694 const std::vector<favicon_base::FaviconID>& icon_ids); 696 const std::vector<favicon_base::FaviconID>& icon_ids);
695 697
698 // Maps the favicon ids in |icon_ids| to URLs in |page_urls| for |icon_type|.
699 // Returns true if the function changed some of the |page_urls| mappings.
sky 2015/06/19 14:49:53 some->at least one
beaudoin 2015/07/06 18:27:24 Done.
700 bool SetFaviconMappingsForPages(
701 const std::vector<GURL>& page_urls,
702 favicon_base::IconType icon_type,
703 const std::vector<favicon_base::FaviconID>& icon_ids);
704
696 // Maps the favicon ids in |icon_ids| to |page_url| for |icon_type|. 705 // Maps the favicon ids in |icon_ids| to |page_url| for |icon_type|.
697 // Returns true if the function changed some of |page_url|'s mappings. 706 // Returns true if the function changed some of |page_url|'s mappings.
698 bool SetFaviconMappingsForPage( 707 bool SetFaviconMappingsForPage(
699 const GURL& page_url, 708 const GURL& page_url,
700 favicon_base::IconType icon_type, 709 favicon_base::IconType icon_type,
701 const std::vector<favicon_base::FaviconID>& icon_ids); 710 const std::vector<favicon_base::FaviconID>& icon_ids);
702 711
703 // Returns all the page URLs in the redirect chain for |page_url|. If there 712 // Returns all the page URLs in the redirect chain for |page_url|. If there
704 // are no known redirects for |page_url|, returns a vector with |page_url|. 713 // are no known redirects for |page_url|, returns a vector with |page_url|.
705 void GetCachedRecentRedirects(const GURL& page_url, 714 void GetCachedRecentRedirects(const GURL& page_url,
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
834 843
835 // List of observers 844 // List of observers
836 base::ObserverList<HistoryBackendObserver> observers_; 845 base::ObserverList<HistoryBackendObserver> observers_;
837 846
838 DISALLOW_COPY_AND_ASSIGN(HistoryBackend); 847 DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
839 }; 848 };
840 849
841 } // namespace history 850 } // namespace history
842 851
843 #endif // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_ 852 #endif // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_
OLDNEW
« no previous file with comments | « no previous file | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698