Cleanup file permission check code in FileAPIMessageFilter

Cleanup file permission check code in FileAPIMessageFilter

- Move detailed permission check code into each MountPointProvider
- Add common enum for fileapi permission policy (webkit/fileapi/file_permission_policy.{h,cc})

BUG=none, cleanup only
TEST=content_browsertests:FileSystemLayoutTest.*,browser_tests:FileBrowser*)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176014

[kinuko, 2013-01-08 14:21:44]

Tom, since this patch is changing the code you've reviewed before (for
http://crbug.com/162114) could you take the first look at the following files to
see if they look ok? Thanks!

content/browser/fileapi/fileapi_message_filter.cc
webkit/fileapi/sandbox_mount_point_provider.cc

(The amount of change is not big)

[Tom Sepez, 2013-01-08 20:26:20]

I think this is right, adding @cevans for another pair of eyes.

[kinuko, 2013-01-09 05:25:08]

Thanks Tom! @cevans if this looks suspicious please raise an alert thanks.

tzik &| ericu: Can you review fileapi code in general
toni: Can you also take a look at changes in cros_mount_point_provider and
fileapi_message_filter

Thanks,

[kinuko, 2013-01-09 05:25:59]

On 2013/01/09 05:25:08, kinuko wrote:
> toni: Can you also take a look at changes in cros_mount_point_provider and
> fileapi_message_filter

Oops, cros tests are failing... will fix.

[tonibarzic, 2013-01-09 06:15:25]

cros_mount_point_provider; fileapi_message_filter lgtm

[ericu, 2013-01-09 17:50:11]

Fileapi stuff generally LGTM.

[Chris Evans, 2013-01-09 20:55:15]

On 2013/01/09 17:50:11, ericu wrote:
> Fileapi stuff generally LGTM.

I took a quick scan; LGTM. We'll review this area in more detail as part of the
IPC audit.