net/base/data_url.cc - Issue 1180393003: Added characters that look like padlocks to URL unescaping blacklist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/data_url.cc

Issue 1180393003: Added characters that look like padlocks to URL unescaping blacklist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename NON_DISPLAY_CHARS to SPOOFING_AND_CONTROL_CHARS. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/data_url.cc

diff --git a/net/base/data_url.cc b/net/base/data_url.cc

index b03d9976ca6cfad855faf517dde6c0a31260fd3d..a5ca92f29e1c8c4f2c8d258b318d0ed6321844bf 100644

--- a/net/base/data_url.cc

+++ b/net/base/data_url.cc

@@ -99,7 +99,7 @@ bool DataURL::Parse(const GURL& url, std::string* mime_type,

if (base64_encoded) {

temp_data = UnescapeURLComponent(temp_data,

UnescapeRule::SPACES | UnescapeRule::URL_SPECIAL_CHARS |

- UnescapeRule::CONTROL_CHARS);

+ UnescapeRule::SPOOFING_AND_CONTROL_CHARS);

}

// Strip whitespace.

@@ -113,7 +113,7 @@ bool DataURL::Parse(const GURL& url, std::string* mime_type,

if (!base64_encoded) {

temp_data = UnescapeURLComponent(temp_data,

UnescapeRule::SPACES | UnescapeRule::URL_SPECIAL_CHARS |

- UnescapeRule::CONTROL_CHARS);

+ UnescapeRule::SPOOFING_AND_CONTROL_CHARS);

}

if (base64_encoded) {

« no previous file with comments | « extensions/browser/api/web_request/form_data_parser.cc ('k') | net/base/escape.h » ('j') | no next file with comments »