Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 1180383002: Introduce (Heap)Vector trait covering zero'ed memory for unused slots. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, Mads Ager (chromium), zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, oilpan-reviews, blink-reviews-rendering, jchaffraix+rendering, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@sof-hittestcache
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce (Heap)Vector trait covering zero'ed memory for unused slots. When a slot/index in a heap vector's backing storage is marked as unused, its value must be cleared out. This so as to prevent later GC tracing or finalization of the backing storage from incorrectly interpreting those bits. The heap vector handles such unused slots by zero-ing out the block of memory it maps to; if that zero'ed block of memory doesn't represent a valid instance of a class type, it cannot be used in heap vectors. Introduce a vector trait controlling if a memset()-zero'ed slot represents a valid value for the Oilpan GC infrastructure to interpret when tracing and finalizing that value. It is needed for the class types where the default constructor maps to a representation that isn't all zero, but that zero'ed representation is still valid for the Oilpan GC to interpret. R=haraken,tkent BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197100

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M Source/core/layout/HitTestResult.h View 1 chunk +1 line, -11 lines 0 comments Download
M Source/platform/heap/Handle.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/heap/HeapAllocator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/TraceTraits.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/VectorTraits.h View 5 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-14 11:26:46 UTC) #2
haraken
LGTM We can use the macro for the CSSValue CL as well.
5 years, 6 months ago (2015-06-15 02:34:26 UTC) #3
tkent
lgtm
5 years, 6 months ago (2015-06-15 03:31:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180383002/20001
5 years, 6 months ago (2015-06-15 05:32:39 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 05:35:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197100

Powered by Google App Engine
This is Rietveld 408576698