Disable the http cache when fetching PAC scripts. Also adds an extra log stat...

net/proxy/proxy_script_fetcher_unittest.cc

 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_script_fetcher.h"
 
 #include "base/file_path.h"
 #include "base/compiler_specific.h"
 #include "base/path_service.h"
 #include "net/base/net_util.h"
+#include "net/disk_cache/disk_cache.h"
+#include "net/http/http_cache.h"
 #include "net/url_request/url_request_unittest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 // TODO(eroman):
 //   - Test canceling an outstanding request.
 //   - Test deleting ProxyScriptFetcher while a request is in progress.
 
 const wchar_t kDocRoot[] = L"net/data/proxy_script_fetcher_unittest";
 
 struct FetchResult {
   int code;
   std::string bytes;
 };
 
 // A non-mock URL request which can access http:// and file:// urls.
 class RequestContext : public URLRequestContext {
  public:
   RequestContext() {
     net::ProxyConfig no_proxy;
     proxy_service_ = net::ProxyService::CreateFixed(no_proxy);
-    http_transaction_factory_ = net::HttpNetworkLayer::CreateFactory(
-        proxy_service_);
+
+    http_transaction_factory_ =
+        new net::HttpCache(net::HttpNetworkLayer::CreateFactory(proxy_service_),
+                           disk_cache::CreateInMemoryCacheBackend(0));
   }
   ~RequestContext() {
     delete http_transaction_factory_;
     delete proxy_service_;
   }
 };
 
 // Helper for doing synch fetches. This object lives in SynchFetcher's
 // |io_thread_| and communicates with SynchFetcher though (|result|, |event|).
 class SynchFetcherThreadHelper {
@@ skipping 189 matching lines @@
   SynchFetcher pac_fetcher;
 
   // Fetch PAC scripts via HTTP with a Content-Disposition header -- should
   // have no effect.
   GURL url = server->TestServerPage("files/downloadable.pac");
   FetchResult result = pac_fetcher.Fetch(url);
   EXPECT_EQ(net::OK, result.code);
   EXPECT_EQ("-downloadable.pac-\n", result.bytes);
 }
 
+TEST_F(ProxyScriptFetcherTest, NoCache) {
+  scoped_refptr<HTTPTestServer> server =
+      HTTPTestServer::CreateServer(kDocRoot, NULL);
+  ASSERT_TRUE(NULL != server.get());
+  SynchFetcher pac_fetcher;
+
+  // Fetch a PAC script whose HTTP headers make it cacheable for 1 hour.
+  GURL url = server->TestServerPage("files/cacheable_1hr.pac");
+  FetchResult result = pac_fetcher.Fetch(url);
+  EXPECT_EQ(net::OK, result.code);
+  EXPECT_EQ("-cacheable_1hr.pac-\n", result.bytes);
+
+  // Now kill the HTTP server.
+  server->SendQuit();
+  EXPECT_TRUE(server->WaitToFinish(20000));
+  server = NULL;
+
+  // Try to fetch the file again -- if should fail, since the server is not
+  // running anymore. (If it were instead being loaded from cache, we would
+  // get a success.
+  result = pac_fetcher.Fetch(url);
+  EXPECT_EQ(net::ERR_CONNECTION_REFUSED, result.code);
+}
+
 TEST_F(ProxyScriptFetcherTest, TooLarge) {
   scoped_refptr<HTTPTestServer> server =
       HTTPTestServer::CreateServer(kDocRoot, NULL);
   ASSERT_TRUE(NULL != server.get());
   SynchFetcher pac_fetcher;
 
   // Set the maximum response size to 50 bytes.
   int prev_size = net::ProxyScriptFetcher::SetSizeConstraintForUnittest(50);
 
   // These two URLs are the same file, but are http:// vs file://
@@ skipping 45 matching lines @@
 
   { // Make sure we can still fetch regular URLs.
     GURL url = server->TestServerPage("files/pac.nsproxy");
     FetchResult result = pac_fetcher.Fetch(url);
     EXPECT_EQ(net::OK, result.code);
     EXPECT_EQ("-pac.nsproxy-\n", result.bytes);
   }
 }
 
 }  // namespace net