IPC: Add new classes required for attachment brokering.

IPC: Add new classes required for attachment brokering.

The implementations of these classes are just stubs.

BUG=493414
Committed: https://crrev.com/151b2f982d66d76337668b0b7f26ab0cd9d7ff34
Cr-Commit-Position: refs/heads/master@{#334676}

[erikchen, 2015-06-15 21:44:21]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-15 21:45:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180313007/1

[erikchen, 2015-06-15 22:46:56]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-15 22:48:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180313007/60001

[erikchen, 2015-06-15 22:59:25]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-15 23:00:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180313007/80001

[erikchen, 2015-06-15 23:04:25]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2015-06-15 23:07:47]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-15 23:08:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180313007/120001

[erikchen, 2015-06-16 00:08:26]

erikchen@chromium.org changed reviewers:
+ wfh@chromium.org

[erikchen, 2015-06-16 00:08:27]

wfh: Please review.

[commit-bot: I haz the power, 2015-06-16 00:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 00:24:50]

Dry run: This issue passed the CQ dry run.

[Will Harris, 2015-06-16 12:42:13]

wfh@chromium.org changed reviewers:
+ tsepez@chromium.org

[Will Harris, 2015-06-16 12:42:27]

+tsepez should look at this.

[Will Harris, 2015-06-16 12:58:17]

I really don't feel familiar enough with the inner details of this IPC code to
review, I've added tsepez to take a look...

https://codereview.chromium.org/1180313007/diff/120001/ipc/handle_attachment_...
File ipc/handle_attachment_win.h (right):

https://codereview.chromium.org/1180313007/diff/120001/ipc/handle_attachment_...
ipc/handle_attachment_win.h:16: HANDLE handle_;
handle_ should be private?

[Tom Sepez, 2015-06-16 17:23:22]

lgtm

https://codereview.chromium.org/1180313007/diff/120001/ipc/brokerable_attachm...
File ipc/brokerable_attachment.h (right):

https://codereview.chromium.org/1180313007/diff/120001/ipc/brokerable_attachm...
ipc/brokerable_attachment.h:16: // An id uniquely identifies an attachment sent
via a broker.
nit: maybe this is nested inside as BrokerableAttachment::AttachmentID

[erikchen, 2015-06-16 17:51:18]

Patchset #8 (id:140001) has been deleted

[erikchen, 2015-06-16 17:56:42]

https://codereview.chromium.org/1180313007/diff/120001/ipc/brokerable_attachm...
File ipc/brokerable_attachment.h (right):

https://codereview.chromium.org/1180313007/diff/120001/ipc/brokerable_attachm...
ipc/brokerable_attachment.h:16: // An id uniquely identifies an attachment sent
via a broker.
On 2015/06/16 17:23:22, Tom Sepez wrote:
> nit: maybe this is nested inside as BrokerableAttachment::AttachmentID

Done.

https://codereview.chromium.org/1180313007/diff/120001/ipc/handle_attachment_...
File ipc/handle_attachment_win.h (right):

https://codereview.chromium.org/1180313007/diff/120001/ipc/handle_attachment_...
ipc/handle_attachment_win.h:16: HANDLE handle_;
On 2015/06/16 12:58:17, Will Harris wrote:
> handle_ should be private?

Classes are private by default. 

I added a private: specifier, since if you were confused by this, other people
will be too. I also moved the method before the member variable.

[erikchen, 2015-06-16 17:56:46]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-06-16 17:56:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1180313007/#ps180001
(title: "Comments from wfh.")

[commit-bot: I haz the power, 2015-06-16 17:57:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180313007/180001

[commit-bot: I haz the power, 2015-06-16 19:22:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 19:22:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-06-16 19:30:01]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-06-16 19:32:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180313007/180001

[commit-bot: I haz the power, 2015-06-16 20:21:00]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2015-06-16 20:23:02]

Patchset 9 (id:??) landed as
https://crrev.com/151b2f982d66d76337668b0b7f26ab0cd9d7ff34
Cr-Commit-Position: refs/heads/master@{#334676}

[Nico, 2015-06-16 22:03:17]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-06-16 22:03:18]

This caused a few style warnings, can you fix please?

FAILED: ninja -t msvc -e environment.x64 --
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC @obj/ipc/ipc.attachment_broker_win.obj.rsp /c
../../ipc/attachment_broker_win.cc /Foobj/ipc/ipc.attachment_broker_win.obj
/Fdobj/ipc/ipc_cc.pdb
In file included from ../../ipc/attachment_broker_win.cc:5:
../..\ipc/attachment_broker_win.h(18,33) :  error: [chromium-style] Overriding
method must be marked with 'override' or 'final'.
  virtual ~AttachmentBrokerWin();
                                ^
                                 override
1 error generated.
FAILED: ninja -t msvc -e environment.x64 --
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC @obj/ipc/ipc.ipc_channel_win.obj.rsp /c
../../ipc/ipc_channel_win.cc /Foobj/ipc/ipc.ipc_channel_win.obj
/Fdobj/ipc/ipc_cc.pdb
In file included from ../../ipc/ipc_channel_win.cc:5:
../..\ipc/ipc_channel_win.h(109,36) :  error: [chromium-style] WeakPtrFactory
members which refer to their outer class must be the last member in the outer
class definition.
  base::WeakPtrFactory<ChannelWin> weak_factory_;
                                   ^
1 error generated.
ninja: build stopped: subcommand failed.

[erikchen, 2015-06-16 22:15:27]

On 2015/06/16 22:03:18, Nico wrote:
> This caused a few style warnings, can you fix please?
> 
> FAILED: ninja -t msvc -e environment.x64 --
> ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
> /showIncludes /FC @obj/ipc/ipc.attachment_broker_win.obj.rsp /c
> ../../ipc/attachment_broker_win.cc /Foobj/ipc/ipc.attachment_broker_win.obj
> /Fdobj/ipc/ipc_cc.pdb
> In file included from ../../ipc/attachment_broker_win.cc:5:
> ../..\ipc/attachment_broker_win.h(18,33) :  error: [chromium-style] Overriding
> method must be marked with 'override' or 'final'.
>   virtual ~AttachmentBrokerWin();
>                                 ^
>                                  override
> 1 error generated.
> FAILED: ninja -t msvc -e environment.x64 --
> ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
> /showIncludes /FC @obj/ipc/ipc.ipc_channel_win.obj.rsp /c
> ../../ipc/ipc_channel_win.cc /Foobj/ipc/ipc.ipc_channel_win.obj
> /Fdobj/ipc/ipc_cc.pdb
> In file included from ../../ipc/ipc_channel_win.cc:5:
> ../..\ipc/ipc_channel_win.h(109,36) :  error: [chromium-style] WeakPtrFactory
> members which refer to their outer class must be the last member in the outer
> class definition.
>   base::WeakPtrFactory<ChannelWin> weak_factory_;
>                                    ^
> 1 error generated.
> ninja: build stopped: subcommand failed.

https://codereview.chromium.org/1179973004/