Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1180313007: IPC: Add new classes required for attachment brokering. (Closed)

Created:
5 years, 6 months ago by erikchen
Modified:
5 years, 6 months ago
Reviewers:
Tom Sepez, Nico, Will Harris
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC: Add new classes required for attachment brokering. The implementations of these classes are just stubs. BUG=493414 Committed: https://crrev.com/151b2f982d66d76337668b0b7f26ab0cd9d7ff34 Cr-Commit-Position: refs/heads/master@{#334676}

Patch Set 1 #

Patch Set 2 : Add some includes. Update GN. #

Patch Set 3 : More minor header file/comment fixes. #

Patch Set 4 : Add message type. #

Patch Set 5 : Move implementation of BrokerableAttachment into .cc. #

Patch Set 6 : Remove internals #

Patch Set 7 : Mark overriding method with override. #

Total comments: 4

Patch Set 8 : Comments from tsepez. #

Patch Set 9 : Comments from wfh. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -0 lines) Patch
M ipc/BUILD.gn View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A ipc/attachment_broker.h View 1 2 3 4 5 6 7 1 chunk +52 lines, -0 lines 0 comments Download
A ipc/attachment_broker_win.h View 1 2 3 4 5 6 7 1 chunk +34 lines, -0 lines 0 comments Download
A ipc/attachment_broker_win.cc View 1 2 3 4 5 6 7 1 chunk +34 lines, -0 lines 0 comments Download
A ipc/brokerable_attachment.h View 1 2 3 4 5 6 7 1 chunk +41 lines, -0 lines 0 comments Download
A ipc/brokerable_attachment.cc View 1 2 3 4 5 6 7 1 chunk +19 lines, -0 lines 0 comments Download
A ipc/handle_attachment_win.h View 1 2 3 4 5 6 7 8 1 chunk +24 lines, -0 lines 0 comments Download
M ipc/ipc.gypi View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M ipc/ipc_message_attachment.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180313007/1
5 years, 6 months ago (2015-06-15 21:45:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180313007/60001
5 years, 6 months ago (2015-06-15 22:48:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180313007/80001
5 years, 6 months ago (2015-06-15 23:00:57 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180313007/120001
5 years, 6 months ago (2015-06-15 23:08:44 UTC) #9
erikchen
wfh: Please review.
5 years, 6 months ago (2015-06-16 00:08:27 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 00:24:50 UTC) #13
Will Harris
+tsepez should look at this.
5 years, 6 months ago (2015-06-16 12:42:27 UTC) #15
Will Harris
I really don't feel familiar enough with the inner details of this IPC code to ...
5 years, 6 months ago (2015-06-16 12:58:17 UTC) #16
Tom Sepez
lgtm https://codereview.chromium.org/1180313007/diff/120001/ipc/brokerable_attachment.h File ipc/brokerable_attachment.h (right): https://codereview.chromium.org/1180313007/diff/120001/ipc/brokerable_attachment.h#newcode16 ipc/brokerable_attachment.h:16: // An id uniquely identifies an attachment sent ...
5 years, 6 months ago (2015-06-16 17:23:22 UTC) #17
erikchen
https://codereview.chromium.org/1180313007/diff/120001/ipc/brokerable_attachment.h File ipc/brokerable_attachment.h (right): https://codereview.chromium.org/1180313007/diff/120001/ipc/brokerable_attachment.h#newcode16 ipc/brokerable_attachment.h:16: // An id uniquely identifies an attachment sent via ...
5 years, 6 months ago (2015-06-16 17:56:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180313007/180001
5 years, 6 months ago (2015-06-16 17:57:14 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/70339)
5 years, 6 months ago (2015-06-16 19:22:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180313007/180001
5 years, 6 months ago (2015-06-16 19:32:12 UTC) #26
commit-bot: I haz the power
Committed patchset #9 (id:180001)
5 years, 6 months ago (2015-06-16 20:21:00 UTC) #27
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/151b2f982d66d76337668b0b7f26ab0cd9d7ff34 Cr-Commit-Position: refs/heads/master@{#334676}
5 years, 6 months ago (2015-06-16 20:23:02 UTC) #28
Nico
This caused a few style warnings, can you fix please? FAILED: ninja -t msvc -e ...
5 years, 6 months ago (2015-06-16 22:03:18 UTC) #30
erikchen
5 years, 6 months ago (2015-06-16 22:15:27 UTC) #31
Message was sent while issue was closed.
On 2015/06/16 22:03:18, Nico wrote:
> This caused a few style warnings, can you fix please?
> 
> FAILED: ninja -t msvc -e environment.x64 --
> ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
> /showIncludes /FC @obj/ipc/ipc.attachment_broker_win.obj.rsp /c
> ../../ipc/attachment_broker_win.cc /Foobj/ipc/ipc.attachment_broker_win.obj
> /Fdobj/ipc/ipc_cc.pdb
> In file included from ../../ipc/attachment_broker_win.cc:5:
> ../..\ipc/attachment_broker_win.h(18,33) :  error: [chromium-style] Overriding
> method must be marked with 'override' or 'final'.
>   virtual ~AttachmentBrokerWin();
>                                 ^
>                                  override
> 1 error generated.
> FAILED: ninja -t msvc -e environment.x64 --
> ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
> /showIncludes /FC @obj/ipc/ipc.ipc_channel_win.obj.rsp /c
> ../../ipc/ipc_channel_win.cc /Foobj/ipc/ipc.ipc_channel_win.obj
> /Fdobj/ipc/ipc_cc.pdb
> In file included from ../../ipc/ipc_channel_win.cc:5:
> ../..\ipc/ipc_channel_win.h(109,36) :  error: [chromium-style] WeakPtrFactory
> members which refer to their outer class must be the last member in the outer
> class definition.
>   base::WeakPtrFactory<ChannelWin> weak_factory_;
>                                    ^
> 1 error generated.
> ninja: build stopped: subcommand failed.

https://codereview.chromium.org/1179973004/

Powered by Google App Engine
This is Rietveld 408576698