Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1180283002: [Sync] Add tab sync latency UMA (Closed)

Created:
5 years, 6 months ago by Nicolas Zea
Modified:
5 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Add tab sync latency UMA Adds a delay measurement before the tab sync data is available to the chrome://history UI from the time the page is opened. BUG=476646 Committed: https://crrev.com/d2fe056a75f3a94645b9404d43ecf56f7f2776e6 Cr-Commit-Position: refs/heads/master@{#335075}

Patch Set 1 #

Patch Set 2 : Self review #

Total comments: 2

Patch Set 3 : Switch to timeticks #

Patch Set 4 : Fix typo #

Patch Set 5 : Fix TimeTicks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/browser/ui/webui/foreign_session_handler.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.cc View 1 2 3 4 3 chunks +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Nicolas Zea
+Bernhard for foreign_session_handler, Alexei for histos.
5 years, 6 months ago (2015-06-13 00:49:27 UTC) #3
Bernhard Bauer
lgtm
5 years, 6 months ago (2015-06-15 08:32:45 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1180283002/diff/40001/chrome/browser/ui/webui/foreign_session_handler.cc File chrome/browser/ui/webui/foreign_session_handler.cc (right): https://codereview.chromium.org/1180283002/diff/40001/chrome/browser/ui/webui/foreign_session_handler.cc#newcode233 chrome/browser/ui/webui/foreign_session_handler.cc:233: base::Time::Now() - load_attempt_time_); Nit: Usually base::TimeTicks:: is used ...
5 years, 6 months ago (2015-06-15 14:33:28 UTC) #5
Nicolas Zea
Thanks! https://codereview.chromium.org/1180283002/diff/40001/chrome/browser/ui/webui/foreign_session_handler.cc File chrome/browser/ui/webui/foreign_session_handler.cc (right): https://codereview.chromium.org/1180283002/diff/40001/chrome/browser/ui/webui/foreign_session_handler.cc#newcode233 chrome/browser/ui/webui/foreign_session_handler.cc:233: base::Time::Now() - load_attempt_time_); On 2015/06/15 14:33:28, Alexei Svitkine ...
5 years, 6 months ago (2015-06-15 18:01:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180283002/60001
5 years, 6 months ago (2015-06-15 18:02:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/81535)
5 years, 6 months ago (2015-06-15 18:20:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180283002/100001
5 years, 6 months ago (2015-06-17 23:56:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/7487)
5 years, 6 months ago (2015-06-18 02:02:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180283002/100001
5 years, 6 months ago (2015-06-18 17:26:41 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 6 months ago (2015-06-18 18:00:17 UTC) #19
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 18:01:13 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d2fe056a75f3a94645b9404d43ecf56f7f2776e6
Cr-Commit-Position: refs/heads/master@{#335075}

Powered by Google App Engine
This is Rietveld 408576698