Issue 1180233005: Do not emit display items for masks and clips that are already cached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1180233005: Do not emit display items for masks and clips that are already cached (Closed)

Created:
4 years, 10 months ago by pdr.

Modified:
4 years, 10 months ago

Reviewers:
fs

CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Do not emit display items for masks and clips that are already cached In https://codereview.chromium.org/1184633004 somebody removed a DisplayRecorder in favor of manually emitting display items. This caused crashes on [1] because it does not check whether the item is already cached. This patch switches both clips and masks to use a drawing recorder with bounds based on the paint invalidation rect. [1] svg/custom/absolute-sized-content-with-resources.xhtml TEST=svg/custom/absolute-sized-content-with-resources.xhtml with sp. BUG=500713 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197350

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -26 lines)			Patch
M	Source/core/paint/SVGClipPainter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/paint/SVGClipPainter.cpp	View	3 chunks	+11 lines, -12 lines	0 comments	Download
M	Source/core/paint/SVGMaskPainter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/paint/SVGMaskPainter.cpp	View	2 chunks	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180233005/1

4 years, 10 months ago (2015-06-18 08:37:55 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-18 12:44:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197350

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages