Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: components/domain_reliability/test_util.cc

Issue 1180223006: Domain Reliability: Simplify configs and reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix memory leak in unittests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/test_util.h ('k') | components/domain_reliability/util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/test_util.cc
diff --git a/components/domain_reliability/test_util.cc b/components/domain_reliability/test_util.cc
index 17c819955d6806678ba63050525cfab0cb3ce4fe..bc816f98a9fc5647fd893ee229c3b0d0a92a9c2c 100644
--- a/components/domain_reliability/test_util.cc
+++ b/components/domain_reliability/test_util.cc
@@ -160,42 +160,21 @@ DomainReliabilityScheduler::Params MakeTestSchedulerParams() {
return params;
}
-scoped_ptr<const DomainReliabilityConfig> MakeTestConfig() {
- return MakeTestConfigWithDomain("example");
+scoped_ptr<DomainReliabilityConfig> MakeTestConfig() {
+ return MakeTestConfigWithOrigin(GURL("https://example/"));
}
-scoped_ptr<const DomainReliabilityConfig> MakeTestConfigWithDomain(
- const std::string& domain) {
+scoped_ptr<DomainReliabilityConfig> MakeTestConfigWithOrigin(
+ const GURL& origin) {
DomainReliabilityConfig* config = new DomainReliabilityConfig();
- DomainReliabilityConfig::Resource* resource;
-
- resource = new DomainReliabilityConfig::Resource();
- resource->name = "always_report";
- resource->url_patterns.push_back(
- new std::string("http://*/always_report"));
- resource->success_sample_rate = 1.0;
- resource->failure_sample_rate = 1.0;
- config->resources.push_back(resource);
-
- resource = new DomainReliabilityConfig::Resource();
- resource->name = "never_report";
- resource->url_patterns.push_back(
- new std::string("http://*/never_report"));
- resource->success_sample_rate = 0.0;
- resource->failure_sample_rate = 0.0;
- config->resources.push_back(resource);
-
- DomainReliabilityConfig::Collector* collector;
- collector = new DomainReliabilityConfig::Collector();
- collector->upload_url = GURL("https://exampleuploader/upload");
- config->collectors.push_back(collector);
-
- config->version = "1";
- config->domain = domain;
+ config->origin = origin;
+ config->collectors.push_back(new GURL("https://exampleuploader/upload"));
+ config->failure_sample_rate = 1.0;
+ config->success_sample_rate = 0.0;
DCHECK(config->IsValid());
- return scoped_ptr<const DomainReliabilityConfig>(config);
+ return scoped_ptr<DomainReliabilityConfig>(config);
}
} // namespace domain_reliability
« no previous file with comments | « components/domain_reliability/test_util.h ('k') | components/domain_reliability/util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698