Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: components/domain_reliability/beacon.h

Issue 1180223006: Domain Reliability: Simplify configs and reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, make requested changes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/beacon.h
diff --git a/components/domain_reliability/beacon.h b/components/domain_reliability/beacon.h
index aba7bf9503b15b49e86d7c32a196d00b8c3c941e..28868f887dbddff1bdf87b1bad00b6491d231ccb 100644
--- a/components/domain_reliability/beacon.h
+++ b/components/domain_reliability/beacon.h
@@ -7,8 +7,10 @@
#include <string>
+#include "base/memory/scoped_vector.h"
#include "base/time/time.h"
#include "components/domain_reliability/domain_reliability_export.h"
+#include "url/gurl.h"
namespace base {
class Value;
@@ -24,13 +26,14 @@ struct DOMAIN_RELIABILITY_EXPORT DomainReliabilityBeacon {
// Converts the Beacon to JSON format for uploading. Calculates the age
// relative to an upload time of |upload_time|.
- base::Value* ToValue(base::TimeTicks upload_time,
- base::TimeTicks last_network_change_time) const;
+ scoped_ptr<base::Value> ToValue(
+ base::TimeTicks upload_time,
+ base::TimeTicks last_network_change_time,
+ const GURL& collector_url,
+ const ScopedVector<std::string>& path_prefixes) const;
Randy Smith (Not in Mondays) 2015/10/29 22:36:10 nit, suggestion: Comment the argument requiremets?
Deprecated (see juliatuttle) 2015/11/02 23:19:30 Done.
// The URL that the beacon is reporting on, if included.
- std::string url;
- // The domain that the beacon is reporting on, if included.
- std::string domain;
+ GURL url;
// The resource name that the beacon is reporting on, if included.
std::string resource;
// Status string (e.g. "ok", "dns.nxdomain", "http.403").

Powered by Google App Engine
This is Rietveld 408576698