Domain Reliability: Simplify configs and reports

components/domain_reliability/google_configs_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/domain_reliability/google_configs.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace domain_reliability {
+
+namespace {
+
+TEST(DomainReliabilityGoogleConfigsTest, Enumerate) {
+  std::vector<DomainReliabilityConfig*> configs;
+  GetAllGoogleConfigs(&configs);

[Randy Smith (Not in Mondays), 2015/11/03 21:48:12]

What are you testing?  (Even if there is something, this seems a proper subset
of the following test).

[Deprecated (see juliatuttle), 2015/11/06 17:22:29]

I do that in tests -- most of my tests have a simple case that just makes sure
the class can be created or such. If you don't like the redundancy, I can remove
this case. (It's basically there to make sure it doesn't crash.)

[Randy Smith (Not in Mondays), 2015/11/09 21:23:24]

In a unittest I don't really care; it's fine.

+}
+
+TEST(DomainReliabilityGoogleConfigsTest, ConfigsAreValid) {
+  std::vector<DomainReliabilityConfig*> configs;
+  GetAllGoogleConfigs(&configs);
+
+  for (auto config : configs)
+    EXPECT_TRUE(config->IsValid());
+}
+
+}  // namespace
+
+}  // namespace domain_reliability