components/domain_reliability/google_configs.h - Issue 1180223006: Domain Reliability: Simplify configs and reports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/domain_reliability/google_configs.h

Issue 1180223006: Domain Reliability: Simplify configs and reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, make requested changes Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/domain_reliability/context_manager.cc ('K') | « components/domain_reliability/context_unittest.cc ('k') | components/domain_reliability/google_configs.cc » ('j') | components/domain_reliability/monitor.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_DOMAIN_RELIABILITY_GOOGLE_CONFIGS_H_

	6 #define COMPONENTS_DOMAIN_RELIABILITY_GOOGLE_CONFIGS_H_

	7

	8 #include "base/memory/scoped_ptr.h"

	9 #include "components/domain_reliability/config.h"

	10 #include "components/domain_reliability/domain_reliability_export.h"

	11

	12 namespace domain_reliability {

	13

	14 void DOMAIN_RELIABILITY_EXPORT GetAllGoogleConfigs(

	15 std::vector<DomainReliabilityConfig> configs_out);
	Randy Smith (Not in Mondays) 2015/10/29 22:36:11 nit, idea (weaker than a suggestion): Did you cons nit, idea (weaker than a suggestion): Did you consider using a ScopedVector and using weak_erase at the point of removing them from the vector? It's all where you push the ugliness, but that feels better to me. (Really, ScopedVector should have a scoped_ptr<> GetAndRemove(iterator) method, but it doesn't, and I'm certain there are subtle C++ arguments against it doing so.) Deprecated (see juliatuttle) 2015/11/02 23:19:30 I did consider it, but it felt uglier to me. :) Show quoted text On 2015/10/29 22:36:11, rdsmith wrote: > nit, idea (weaker than a suggestion): Did you consider using a ScopedVector and > using weak_erase at the point of removing them from the vector? It's all where > you push the ugliness, but that feels better to me. (Really, ScopedVector > should have a scoped_ptr<> GetAndRemove(iterator) method, but it doesn't, and > I'm certain there are subtle C++ arguments against it doing so.) I did consider it, but it felt uglier to me. :) Randy Smith (Not in Mondays) 2015/11/03 21:48:12 Acknowledged. Show quoted text On 2015/11/02 23:19:30, ttuttle wrote: > On 2015/10/29 22:36:11, rdsmith wrote: > > nit, idea (weaker than a suggestion): Did you consider using a ScopedVector > and > > using weak_erase at the point of removing them from the vector? It's all > where > > you push the ugliness, but that feels better to me. (Really, ScopedVector > > should have a scoped_ptr<> GetAndRemove(iterator) method, but it doesn't, and > > I'm certain there are subtle C++ arguments against it doing so.) > > I did consider it, but it felt uglier to me. :) Acknowledged.
	16

	17 } // namespace domain_reliability

	18

	19 #endif // COMPONENTS_DOMAIN_RELIABILITY_GOOGLE_CONFIGS_H_

OLD	NEW