Domain Reliability: Simplify configs and reports

components/domain_reliability/context_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/context.h"
 
 #include <map>
 #include <string>
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/domain_reliability/beacon.h"
 #include "components/domain_reliability/dispatcher.h"
 #include "components/domain_reliability/scheduler.h"
 #include "components/domain_reliability/test_util.h"
 #include "components/domain_reliability/uploader.h"
 #include "net/base/net_errors.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace domain_reliability {
 namespace {
 
-typedef std::vector<DomainReliabilityBeacon> BeaconVector;
+typedef std::vector<const DomainReliabilityBeacon*> BeaconVector;
 
-DomainReliabilityBeacon MakeBeacon(MockableTime* time) {
-  DomainReliabilityBeacon beacon;
-  beacon.domain = "localhost";
-  beacon.status = "ok";
-  beacon.chrome_error = net::OK;
-  beacon.server_ip = "127.0.0.1";
-  beacon.was_proxied = false;
-  beacon.protocol = "HTTP";
-  beacon.http_response_code = 200;
-  beacon.elapsed = base::TimeDelta::FromMilliseconds(250);
-  beacon.start_time = time->NowTicks() - beacon.elapsed;
-  return beacon;
+scoped_ptr<DomainReliabilityBeacon> MakeBeacon(MockableTime* time) {
+  scoped_ptr<DomainReliabilityBeacon> beacon(new DomainReliabilityBeacon());
+  beacon->url = GURL("https://localhost/");
+  beacon->status = "tcp.connection_reset";
+  beacon->chrome_error = net::ERR_CONNECTION_RESET;
+  beacon->server_ip = "127.0.0.1";
+  beacon->was_proxied = false;
+  beacon->protocol = "HTTP";
+  beacon->http_response_code = -1;
+  beacon->elapsed = base::TimeDelta::FromMilliseconds(250);
+  beacon->start_time = time->NowTicks() - beacon->elapsed;
+  return beacon.Pass();
 }
 
 class DomainReliabilityContextTest : public testing::Test {
  protected:
   DomainReliabilityContextTest()
       : last_network_change_time_(time_.NowTicks()),
         dispatcher_(&time_),
         params_(MakeTestSchedulerParams()),
         uploader_(base::Bind(&DomainReliabilityContextTest::OnUploadRequest,
                              base::Unretained(this))),
@@ skipping 34 matching lines @@
     upload_callback_.Run(result);
     upload_pending_ = false;
   }
 
   bool CheckNoBeacons() {
     BeaconVector beacons;
     context_.GetQueuedBeaconsForTesting(&beacons);
     return beacons.empty();
   }
 
-  bool CheckCounts(size_t index,
-                   unsigned expected_successful,
-                   unsigned expected_failed) {
-    unsigned successful, failed;
-    context_.GetRequestCountsForTesting(index, &successful, &failed);
-    return successful == expected_successful && failed == expected_failed;
-  }
-
   MockTime time_;
   base::TimeTicks last_network_change_time_;
   DomainReliabilityDispatcher dispatcher_;
   DomainReliabilityScheduler::Params params_;
   MockUploader uploader_;
   std::string upload_reporter_string_;
   DomainReliabilityContext context_;
 
  private:
   void OnUploadRequest(
       const std::string& report_json,
       const GURL& upload_url,
       const DomainReliabilityUploader::UploadCallback& callback) {
     DCHECK(!upload_pending_);
     upload_report_ = report_json;
     upload_url_ = upload_url;
     upload_callback_ = callback;
     upload_pending_ = true;
   }
 
   bool upload_pending_;
   std::string upload_report_;
   GURL upload_url_;
   DomainReliabilityUploader::UploadCallback upload_callback_;
 };
 
 TEST_F(DomainReliabilityContextTest, Create) {
   EXPECT_TRUE(CheckNoBeacons());
-  EXPECT_TRUE(CheckCounts(0, 0, 0));
-  EXPECT_TRUE(CheckCounts(1, 0, 0));
 }
 
-TEST_F(DomainReliabilityContextTest, NoResource) {
-  GURL url("http://example/no_resource");
-  DomainReliabilityBeacon beacon = MakeBeacon(&time_);
-  context_.OnBeacon(url, beacon);
-
-  EXPECT_TRUE(CheckNoBeacons());
-  EXPECT_TRUE(CheckCounts(0, 0, 0));
-  EXPECT_TRUE(CheckCounts(1, 0, 0));
-}
-
-TEST_F(DomainReliabilityContextTest, NeverReport) {
-  GURL url("http://example/never_report");
-  DomainReliabilityBeacon beacon = MakeBeacon(&time_);
-  context_.OnBeacon(url, beacon);
-
-  EXPECT_TRUE(CheckNoBeacons());
-  EXPECT_TRUE(CheckCounts(0, 0, 0));
-  EXPECT_TRUE(CheckCounts(1, 1, 0));
-}
-
-TEST_F(DomainReliabilityContextTest, AlwaysReport) {
-  GURL url("http://example/always_report");
-  DomainReliabilityBeacon beacon = MakeBeacon(&time_);
-  context_.OnBeacon(url, beacon);
+TEST_F(DomainReliabilityContextTest, Report) {
+  context_.OnBeacon(MakeBeacon(&time_));
 
   BeaconVector beacons;
   context_.GetQueuedBeaconsForTesting(&beacons);
   EXPECT_EQ(1u, beacons.size());
-  EXPECT_TRUE(CheckCounts(0, 1, 0));
-  EXPECT_TRUE(CheckCounts(1, 0, 0));
 }
 
-TEST_F(DomainReliabilityContextTest, ReportUpload) {
-  GURL url("http://example/always_report");
-  DomainReliabilityBeacon beacon = MakeBeacon(&time_);
-  context_.OnBeacon(url, beacon);
+TEST_F(DomainReliabilityContextTest, Upload) {
+  context_.OnBeacon(MakeBeacon(&time_));
 
   BeaconVector beacons;
   context_.GetQueuedBeaconsForTesting(&beacons);
   EXPECT_EQ(1u, beacons.size());
-  EXPECT_TRUE(CheckCounts(0, 1, 0));
-  EXPECT_TRUE(CheckCounts(1, 0, 0));
 
+  // TODO(ttuttle): Update string.

[davidben, 2015/10/20 23:35:54]

(What's this mean?)

[Deprecated (see juliatuttle), 2015/10/26 19:08:41]

Whoops, must've left it from before.

   // N.B.: Assumes max_delay is 5 minutes.
   const char* kExpectedReport = "{"
-      "\"config_version\":\"1\","
-      "\"entries\":[{\"domain\":\"localhost\","
-          "\"http_response_code\":200,\"network_changed\":false,"
-          "\"protocol\":\"HTTP\",\"request_age_ms\":300250,"
-          "\"request_elapsed_ms\":250,\"resource\":\"always_report\","
-          "\"server_ip\":\"127.0.0.1\",\"status\":\"ok\","
-          "\"was_proxied\":false}],"
-      "\"reporter\":\"test-reporter\","
-      "\"resources\":[{\"failed_requests\":0,\"name\":\"always_report\","
-          "\"successful_requests\":1}]}";
+    "\"entries\":["
+      "{\"failure_data\":{\"custom_error\":\"net::ERR_CONNECTION_RESET\"},"
+      "\"network_changed\":false,\"protocol\":\"HTTP\","
+      "\"request_age_ms\":300250,\"request_elapsed_ms\":250,"
+      "\"server_ip\":\"127.0.0.1\",\"status\":\"tcp.connection_reset\","
+      "\"url\":\"https://localhost/\",\"was_proxied\":false}],"
+      "\"reporter\":\"test-reporter\"}";
 
   time_.Advance(max_delay());
   EXPECT_TRUE(upload_pending());
   EXPECT_EQ(kExpectedReport, upload_report());
   EXPECT_EQ(GURL("https://exampleuploader/upload"), upload_url());
 
   DomainReliabilityUploader::UploadResult result;
   result.status = DomainReliabilityUploader::UploadResult::SUCCESS;
   CallUploadCallback(result);
 
   EXPECT_TRUE(CheckNoBeacons());
-  EXPECT_TRUE(CheckCounts(0, 0, 0));
-  EXPECT_TRUE(CheckCounts(1, 0, 0));
 }
 
-TEST_F(DomainReliabilityContextTest, ReportUpload_NetworkChanged) {

[davidben, 2015/10/20 23:35:54]

What happened to this test? (I still see a network_changed field.)

[Deprecated (see juliatuttle), 2015/10/26 19:08:41]

I must've had a good reason for removing it at the time, but I see no good
reason now, so I'm adding it back.

-  GURL url("http://example/always_report");
-  DomainReliabilityBeacon beacon = MakeBeacon(&time_);
-  context_.OnBeacon(url, beacon);
-
-  BeaconVector beacons;
-  context_.GetQueuedBeaconsForTesting(&beacons);
-  EXPECT_EQ(1u, beacons.size());
-  EXPECT_TRUE(CheckCounts(0, 1, 0));
-  EXPECT_TRUE(CheckCounts(1, 0, 0));
-
-  // N.B.: Assumes max_delay is 5 minutes.
-  const char* kExpectedReport = "{"
-      "\"config_version\":\"1\","
-      "\"entries\":[{\"domain\":\"localhost\","
-          "\"http_response_code\":200,\"network_changed\":true,"
-          "\"protocol\":\"HTTP\",\"request_age_ms\":300250,"
-          "\"request_elapsed_ms\":250,\"resource\":\"always_report\","
-          "\"server_ip\":\"127.0.0.1\",\"status\":\"ok\","
-          "\"was_proxied\":false}],"
-      "\"reporter\":\"test-reporter\","
-      "\"resources\":[{\"failed_requests\":0,\"name\":\"always_report\","
-          "\"successful_requests\":1}]}";
-
-  // Simulate a network change after the request but before the upload.
-  last_network_change_time_ = time_.NowTicks();
-  time_.Advance(max_delay());
-
-  EXPECT_TRUE(upload_pending());
-  EXPECT_EQ(kExpectedReport, upload_report());
-  EXPECT_EQ(GURL("https://exampleuploader/upload"), upload_url());
-
-  DomainReliabilityUploader::UploadResult result;
-  result.status = DomainReliabilityUploader::UploadResult::SUCCESS;
-  CallUploadCallback(result);
-
-  EXPECT_TRUE(CheckNoBeacons());
-  EXPECT_TRUE(CheckCounts(0, 0, 0));
-  EXPECT_TRUE(CheckCounts(1, 0, 0));
-}
+// TODO(ttuttle): Add beacon_unittest.cc to test serialization.
 
 }  // namespace
 }  // namespace domain_reliability