Domain Reliability: Simplify configs and reports

components/domain_reliability/config.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Make sure stdint.h includes SIZE_MAX. (See C89, p259, footnote 221.)
 #ifndef __STDC_LIMIT_MACROS
 #define __STDC_LIMIT_MACROS 1
 #endif
 
 #include "components/domain_reliability/config.h"
 
 #include <stdint.h>
 
 #include "base/json/json_reader.h"
 #include "base/json/json_value_converter.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/rand_util.h"
 #include "base/strings/pattern.h"
 #include "base/strings/string_util.h"
 
 namespace {
 
-bool ConvertURL(const base::StringPiece& string_piece, GURL* url) {
-  *url = GURL(string_piece.as_string());
+bool ConvertURL(const base::Value* value, GURL* url) {
+  std::string url_string;
+  if (!value->GetAsString(&url_string))
+    return false;
+  *url = GURL(url_string);
   return url->is_valid();
 }
 
-bool IsValidSampleRate(double p) { return p >= 0.0 && p <= 1.0; }
+bool ConvertOrigin(const base::Value* value, GURL* url) {
+  return ConvertURL(value, url) && !url->has_username() &&
+         !url->has_password() && url->scheme() == "https" &&

[davidben, 2015/10/20 23:35:54]

Nit: SchemeIs("https"). scheme() actually makes a temporary string apparently.

[Deprecated (see juliatuttle), 2015/10/26 19:08:41]

Done.

+         url->path() == "/" && !url->has_query() && !url->has_ref();

[davidben, 2015/10/20 23:35:54]

Nit: path() -> path_piece() to avoid a temporary string.

[Deprecated (see juliatuttle), 2015/10/26 19:08:41]

Done.

+}
+
+bool IsValidSampleRate(double p) {
+  return p >= 0.0 && p <= 1.0;
+}
 
 }  // namespace
 
 namespace domain_reliability {
 
-// static
-const size_t DomainReliabilityConfig::kInvalidResourceIndex = SIZE_MAX;
-
-DomainReliabilityConfig::Resource::Resource() {
+DomainReliabilityConfig::DomainReliabilityConfig()
+    : success_sample_rate(-1.0), failure_sample_rate(-1.0) {
 }
-DomainReliabilityConfig::Resource::~Resource() {}
-
-bool DomainReliabilityConfig::Resource::MatchesUrl(const GURL& url) const {
-  const std::string& spec = url.spec();
-
-  for (const auto& url_pattern : url_patterns) {
-    if (base::MatchPattern(spec, *url_pattern))
-      return true;
-  }
-
-  return false;
-}
-
-bool DomainReliabilityConfig::Resource::DecideIfShouldReportRequest(
-    bool success) const {
-  double sample_rate = success ? success_sample_rate : failure_sample_rate;
-  DCHECK(IsValidSampleRate(sample_rate));
-  return base::RandDouble() < sample_rate;
-}
-
-// static
-void DomainReliabilityConfig::Resource::RegisterJSONConverter(
-    base::JSONValueConverter<DomainReliabilityConfig::Resource>* converter) {
-  converter->RegisterStringField("resource_name", &Resource::name);
-  converter->RegisterRepeatedString("url_patterns", &Resource::url_patterns);
-  converter->RegisterDoubleField("success_sample_rate",
-                                 &Resource::success_sample_rate);
-  converter->RegisterDoubleField("failure_sample_rate",
-                                 &Resource::failure_sample_rate);
-}
-
-bool DomainReliabilityConfig::Resource::IsValid() const {
-  return !name.empty() && !url_patterns.empty() &&
-      IsValidSampleRate(success_sample_rate) &&
-      IsValidSampleRate(failure_sample_rate);
-}
-
-DomainReliabilityConfig::Collector::Collector() {}
-DomainReliabilityConfig::Collector::~Collector() {}
-
-// static
-void DomainReliabilityConfig::Collector::RegisterJSONConverter(
-    base::JSONValueConverter<DomainReliabilityConfig::Collector>* converter) {
-  converter->RegisterCustomField<GURL>("upload_url", &Collector::upload_url,
-                                       &ConvertURL);
-}
-
-bool DomainReliabilityConfig::Collector::IsValid() const {
-  return upload_url.is_valid();
-}
-
-DomainReliabilityConfig::DomainReliabilityConfig() {}
 DomainReliabilityConfig::~DomainReliabilityConfig() {}
 
 // static
 scoped_ptr<const DomainReliabilityConfig> DomainReliabilityConfig::FromJSON(
     const base::StringPiece& json) {
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
   tracked_objects::ScopedTracker tracking_profile(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "436671 DomainReliabilityConfig::FromJSON"));
   scoped_ptr<base::Value> value = base::JSONReader::Read(json);
   base::JSONValueConverter<DomainReliabilityConfig> converter;
   scoped_ptr<DomainReliabilityConfig> config(new DomainReliabilityConfig());
 
   // If we can parse and convert the JSON into a valid config, return that.
   if (value && converter.Convert(*value, config.get()) && config->IsValid())
     return config.Pass();
   return scoped_ptr<const DomainReliabilityConfig>();
 }
 
 bool DomainReliabilityConfig::IsValid() const {
-  if (domain.empty() || resources.empty() || collectors.empty())
+  if (!origin.is_valid() || collectors.empty() ||
+      !IsValidSampleRate(success_sample_rate) ||
+      !IsValidSampleRate(failure_sample_rate)) {
     return false;
-
-  for (auto& resource : resources) {
-    if (!resource->IsValid())
-      return false;
   }
 
-  for (auto& collector : collectors) {
-    if (!collector->IsValid())
+  for (const auto& url : collectors) {
+    if (!url->is_valid())
       return false;
   }
 
   return true;
 }
 
-size_t DomainReliabilityConfig::GetResourceIndexForUrl(const GURL& url) const {
-  // Removes username, password, and fragment.
-  GURL sanitized_url = url.GetAsReferrer();
-
-  for (size_t i = 0; i < resources.size(); ++i) {
-    if (resources[i]->MatchesUrl(sanitized_url))
-      return i;
-  }
-
-  return kInvalidResourceIndex;
+bool DomainReliabilityConfig::DecideIfShouldReportRequest(bool success) const {
+  double sample_rate = success ? success_sample_rate : failure_sample_rate;
+  return base::RandDouble() < sample_rate;
 }
 
 // static
 void DomainReliabilityConfig::RegisterJSONConverter(
     base::JSONValueConverter<DomainReliabilityConfig>* converter) {
-  converter->RegisterStringField("config_version",
-                                 &DomainReliabilityConfig::version);
-  converter->RegisterStringField("monitored_domain",
-                                 &DomainReliabilityConfig::domain);
-  converter->RegisterRepeatedMessage("monitored_resources",
-                                     &DomainReliabilityConfig::resources);
-  converter->RegisterRepeatedMessage("collectors",
-                                     &DomainReliabilityConfig::collectors);
+  converter->RegisterCustomValueField<GURL>(
+      "origin", &DomainReliabilityConfig::origin, &ConvertOrigin);
+  converter->RegisterBoolField("include_subdomains",
+                               &DomainReliabilityConfig::include_subdomains);
+  converter->RegisterRepeatedCustomValue(
+      "collectors", &DomainReliabilityConfig::collectors, &ConvertURL);
+  converter->RegisterRepeatedString("path_prefixes",
+                                    &DomainReliabilityConfig::path_prefixes);
+  converter->RegisterDoubleField("success_sample_rate",
+                                 &DomainReliabilityConfig::success_sample_rate);
+  converter->RegisterDoubleField("failure_sample_rate",
+                                 &DomainReliabilityConfig::failure_sample_rate);
 }
 
 }  // namespace domain_reliability