Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1180223005: Expose SkFaceRec less. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Expose SkFaceRec less. The SkFaceRec class is some data which needs to remain alive for the life of an FT_Face. ref_ft_face returns SkFaceRec, but confusingly unref_ft_face takes an FT_Face. Since no one was using the SkFaceRec for anything other than accessing the FT_Face, have ref_ft_face return FT_Face instead and remove the unused SkFaceRec pointer from the scaler context. Committed: https://skia.googlesource.com/skia/+/13a007d9df7769d3c63998dfeadda5ca17f1d15a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -30 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 12 chunks +17 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180223005/1
5 years, 6 months ago (2015-06-18 22:24:00 UTC) #2
bungeman-skia
5 years, 6 months ago (2015-06-18 22:24:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-18 22:29:16 UTC) #6
mtklein
lgtm!
5 years, 6 months ago (2015-06-19 12:08:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180223005/1
5 years, 6 months ago (2015-06-19 12:09:05 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 12:09:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/13a007d9df7769d3c63998dfeadda5ca17f1d15a

Powered by Google App Engine
This is Rietveld 408576698