Dampen old generation allocation limit after scavenge if allocation rate is low.

Dampen old generation allocation limit after scavenge if allocation rate is low.

BUG=chromium:491907, chromium:499815
LOG=NO

Committed: https://crrev.com/084d1f3db31df7fac8713c953999a1d983c1856f
Cr-Commit-Position: refs/heads/master@{#29072}

[ulan, 2015-06-16 14:47:59]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2015-06-16 14:47:59]

PTAL. Next step is to remove the idle limit.

[Hannes Payer (out of office), 2015-06-16 22:29:22]

lgtm, just nits

https://codereview.chromium.org/1180203003/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1180203003/diff/1/src/heap/heap.cc#newcode5588
src/heap/heap.cc:5588: PrintIsolate(isolate_, "Dampen: old size: %"
V8_PTR_PREFIX
old limit

https://codereview.chromium.org/1180203003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1180203003/diff/1/src/heap/heap.h#newcode1179
src/heap/heap.h:1179: // Decreases the allocation limit if the the allocation
rate is low.
This function does not depend on low allocation rate, we check that outside.
Just say here that this function may decrease the allocation limit if the new
limit based on the given parameters is lower than the current limit.

[ulan, 2015-06-17 08:47:46]

Thanks

https://codereview.chromium.org/1180203003/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1180203003/diff/1/src/heap/heap.cc#newcode5588
src/heap/heap.cc:5588: PrintIsolate(isolate_, "Dampen: old size: %"
V8_PTR_PREFIX
On 2015/06/16 22:29:21, Hannes Payer wrote:
> old limit

Done.

https://codereview.chromium.org/1180203003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1180203003/diff/1/src/heap/heap.h#newcode1179
src/heap/heap.h:1179: // Decreases the allocation limit if the the allocation
rate is low.
On 2015/06/16 22:29:22, Hannes Payer wrote:
> This function does not depend on low allocation rate, we check that outside.
> Just say here that this function may decrease the allocation limit if the new
> limit based on the given parameters is lower than the current limit.

Done.

[ulan, 2015-06-17 08:47:48]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-06-17 08:47:49]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1180203003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-06-17 08:48:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180203003/20001

[commit-bot: I haz the power, 2015-06-17 09:15:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-17 09:15:59]

Patchset 2 (id:??) landed as
https://crrev.com/084d1f3db31df7fac8713c953999a1d983c1856f
Cr-Commit-Position: refs/heads/master@{#29072}