src/object-observe.js - Issue 11802003: Add API for access checks on observed objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/object-observe.js

Issue 11802003: Add API for access checks on observed objects (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/object-observe.js

diff --git a/src/object-observe.js b/src/object-observe.js

index d0a84f69c3eec5e45eec71043bdc52cccb829759..8ac8295c3dc3dfda28aad63abec3ab58d5849b42 100644

--- a/src/object-observe.js

+++ b/src/object-observe.js

@@ -74,6 +74,10 @@ function ObjectObserve(object, callback) {

if (ObjectIsFrozen(callback))

throw MakeTypeError("observe_callback_frozen");

+ // Not part of the spec, but also not allowed

+ if (!%ObjectObserveAllowed(object))

+ throw MakeTypeError("observe_access_check_failed");

if (!observerInfoMap.has(callback)) {

observerInfoMap.set(callback, {

pendingChangeRecords: null,

« no previous file with comments | « src/messages.js ('k') | src/objects.h » ('j') | no next file with comments »