Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1180193003: Revert of Update V8 DEPS. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
v8-autoroll
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Update V8 DEPS. (patchset #1 id:1 of https://codereview.chromium.org/1179703005/) Reason for revert: [Sheriff] gyp change breaks calling gyp on XP: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/2849 Original issue's description: > Update V8 DEPS. > > Rolling v8/build/gyp to fdcd8bc10c935eff13b391644b01460593c46861 > > Rolling v8/tools/clang to 4cc9c6714533a07ba02ca01ed04557f055820532 > > TBR=machenbach@chromium.org > > Committed: https://crrev.com/6e7e5e833c8bddf7d6a97cd3c01f0afe5a882bd6 > Cr-Commit-Position: refs/heads/master@{#29059} TBR=v8-autoroll@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ce3b5350826b9453aa1081bba04a7c0efd58db46 Cr-Commit-Position: refs/heads/master@{#29060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of Update V8 DEPS.
5 years, 6 months ago (2015-06-17 05:38:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180193003/1
5 years, 6 months ago (2015-06-17 05:38:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 05:38:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ce3b5350826b9453aa1081bba04a7c0efd58db46 Cr-Commit-Position: refs/heads/master@{#29060}
5 years, 6 months ago (2015-06-17 05:38:50 UTC) #4
Michael Achenbach
5 years, 6 months ago (2015-06-17 08:57:58 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1190933002/ by machenbach@chromium.org.

The reason for reverting is: Retry with landmine..

Powered by Google App Engine
This is Rietveld 408576698