Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1180163002: Print command to be executed in verbose mode (Closed)

Created:
5 years, 6 months ago by djsollen
Modified:
5 years, 6 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Print command to be executed in verbose mode Committed: https://skia.googlesource.com/skia/+/f793cd09136da89b2e7b425a5ad69b3d977404d5

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M platform_tools/android/bin/android_run_skia View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
djsollen
5 years, 6 months ago (2015-06-12 17:03:04 UTC) #2
borenet
LGTM https://codereview.chromium.org/1180163002/diff/1/platform_tools/android/bin/android_run_skia File platform_tools/android/bin/android_run_skia (right): https://codereview.chromium.org/1180163002/diff/1/platform_tools/android/bin/android_run_skia#newcode38 platform_tools/android/bin/android_run_skia:38: verbose "BEGIN COMMAND FILE CONTENTS" Is there a ...
5 years, 6 months ago (2015-06-12 17:17:12 UTC) #3
djsollen
how about this?
5 years, 6 months ago (2015-06-12 17:23:39 UTC) #4
borenet
On 2015/06/12 17:23:39, djsollen wrote: > how about this? Genius!
5 years, 6 months ago (2015-06-12 17:26:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180163002/20001
5 years, 6 months ago (2015-06-12 17:44:24 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 17:50:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f793cd09136da89b2e7b425a5ad69b3d977404d5

Powered by Google App Engine
This is Rietveld 408576698