Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1180153002: base: Remove MessageLoopProxy (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
Reviewers:
danakj, sdefresne
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove MessageLoopProxy BUG=465354 Committed: https://crrev.com/b1f02993d46e10a58aeda7acc299350381046fa6 Cr-Commit-Position: refs/heads/master@{#335277}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -713 lines) Patch
M base/BUILD.gn View 1 2 chunks +3 lines, -6 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -4 lines 0 comments Download
M base/message_loop/message_loop.h View 3 chunks +4 lines, -14 lines 0 comments Download
M base/message_loop/message_loop.cc View 4 chunks +8 lines, -10 lines 0 comments Download
D base/message_loop/message_loop_proxy.h View 1 chunk +0 lines, -50 lines 0 comments Download
D base/message_loop/message_loop_proxy.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D base/message_loop/message_loop_proxy_impl.h View 1 chunk +0 lines, -58 lines 0 comments Download
D base/message_loop/message_loop_proxy_impl.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D base/message_loop/message_loop_proxy_impl_unittest.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D base/message_loop/message_loop_proxy_unittest.cc View 1 chunk +0 lines, -266 lines 0 comments Download
A + base/message_loop/message_loop_task_runner.h View 4 chunks +15 lines, -15 lines 0 comments Download
A + base/message_loop/message_loop_task_runner.cc View 3 chunks +8 lines, -18 lines 0 comments Download
A + base/message_loop/message_loop_task_runner_unittest.cc View 13 chunks +139 lines, -47 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M base/task_runner_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread.h View 1 chunk +0 lines, -12 lines 0 comments Download
M base/threading/thread_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 31 (13 generated)
Sami
This one isn't quite ready to land since some of the cleanup patches are still ...
5 years, 6 months ago (2015-06-12 15:54:00 UTC) #2
danakj
LGTM when it works. Nice job!
5 years, 6 months ago (2015-06-12 17:49:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180153002/1
5 years, 6 months ago (2015-06-17 18:08:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/82521)
5 years, 6 months ago (2015-06-17 18:21:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180153002/20001
5 years, 6 months ago (2015-06-18 00:39:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/7507)
5 years, 6 months ago (2015-06-18 03:20:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180153002/20001
5 years, 6 months ago (2015-06-18 05:21:15 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/36401)
5 years, 6 months ago (2015-06-18 07:34:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180153002/20001
5 years, 6 months ago (2015-06-18 15:39:20 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/36530)
5 years, 6 months ago (2015-06-18 17:45:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180153002/20001
5 years, 6 months ago (2015-06-18 17:54:10 UTC) #22
sdefresne
On 2015/06/18 at 17:54:10, commit-bot wrote: > CQ is trying da patch. Follow status at ...
5 years, 6 months ago (2015-06-18 18:49:08 UTC) #23
Sami
On 2015/06/18 18:49:08, sdefresne wrote: > On 2015/06/18 at 17:54:10, commit-bot wrote: > > CQ ...
5 years, 6 months ago (2015-06-18 18:53:49 UTC) #25
sdefresne
On 2015/06/18 at 18:53:49, skyostil wrote: > On 2015/06/18 18:49:08, sdefresne wrote: > > On ...
5 years, 6 months ago (2015-06-18 19:14:04 UTC) #26
sdefresne
On 2015/06/18 at 19:14:04, sdefresne wrote: > On 2015/06/18 at 18:53:49, skyostil wrote: > > ...
5 years, 6 months ago (2015-06-19 15:21:40 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180153002/20001
5 years, 6 months ago (2015-06-19 15:22:12 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 17:23:03 UTC) #30
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 17:23:48 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1f02993d46e10a58aeda7acc299350381046fa6
Cr-Commit-Position: refs/heads/master@{#335277}

Powered by Google App Engine
This is Rietveld 408576698