Test fix: missing check for JSArray.

src/objects.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 9843 matching lines @@
     }
   }
   // Convert to fast double elements if appropriate.
   if (HasFastSmiElements() && !value->IsSmi() && value->IsNumber()) {
     // Consider fixing the boilerplate as well if we have one.
     ElementsKind to_kind = IsHoleyElementsKind(elements_kind)
         ? FAST_HOLEY_DOUBLE_ELEMENTS
         : FAST_DOUBLE_ELEMENTS;
 
     MaybeObject* trans = PossiblyTransitionArrayBoilerplate(to_kind);
-    if (trans != NULL && trans->IsFailure()) return trans;
+    if (trans->IsFailure()) return trans;
 
     MaybeObject* maybe =
         SetFastDoubleElementsCapacityAndLength(new_capacity, array_length);
     if (maybe->IsFailure()) return maybe;
     FixedDoubleArray::cast(elements())->set(index, value->Number());
     ValidateElements();
     return value;
   }
   // Change elements kind from Smi-only to generic FAST if necessary.
   if (HasFastSmiElements() && !value->IsSmi()) {
@@ skipping 524 matching lines @@
 Handle<Object> JSObject::TransitionElementsKind(Handle<JSObject> object,
                                                 ElementsKind to_kind) {
   CALL_HEAP_FUNCTION(object->GetIsolate(),
                      object->TransitionElementsKind(to_kind),
                      Object);
 }
 
 
 MaybeObject* JSObject::PossiblyTransitionArrayBoilerplate(
     ElementsKind to_kind) {
-  ASSERT(IsJSArray());
   MaybeObject* ret = NULL;
-  AllocationSiteInfo* info = AllocationSiteInfo::FindForJSObject(this);
-  if (info != NULL) {
-    JSObject* payload = JSObject::cast(info->payload());
-    if (payload->GetElementsKind() != to_kind) {
-      if (IsMoreGeneralElementsKindTransition(payload->GetElementsKind(),
-                                              to_kind)) {
-        ret = payload->TransitionElementsKind(to_kind);
+  if (IsJSArray()) {
+    AllocationSiteInfo* info = AllocationSiteInfo::FindForJSObject(this);
+    if (info != NULL) {
+      JSObject* payload = JSObject::cast(info->payload());
+      if (payload->GetElementsKind() != to_kind) {
+        if (IsMoreGeneralElementsKindTransition(payload->GetElementsKind(),
+                                                to_kind)) {
+          ret = payload->TransitionElementsKind(to_kind);
+        }
       }
     }
   }
   return ret;
 }
 
 
 MaybeObject* JSObject::TransitionElementsKind(ElementsKind to_kind) {
   ASSERT(!map()->is_observed());
   ElementsKind from_kind = map()->elements_kind();
 
   if (IsFastHoleyElementsKind(from_kind)) {
     to_kind = GetHoleyElementsKind(to_kind);
   }
 
   if (from_kind == to_kind) return this;
 
   MaybeObject* trans = PossiblyTransitionArrayBoilerplate(to_kind);
-  if (trans != NULL && trans->IsFailure()) return trans;
+  if (trans->IsFailure()) return trans;
 
   Isolate* isolate = GetIsolate();
   if (elements() == isolate->heap()->empty_fixed_array() ||
       (IsFastSmiOrObjectElementsKind(from_kind) &&
        IsFastSmiOrObjectElementsKind(to_kind)) ||
       (from_kind == FAST_DOUBLE_ELEMENTS &&
        to_kind == FAST_HOLEY_DOUBLE_ELEMENTS)) {
     ASSERT(from_kind != TERMINAL_FAST_ELEMENTS_KIND);
     // No change is needed to the elements() buffer, the transition
     // only requires a map change.
@@ skipping 3332 matching lines @@
   set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
   set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
   set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
   set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
   set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
   set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
   set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
 }
 
 } }  // namespace v8::internal