Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: ui/views/widget/widget.h

Issue 11801027: More work to make ash_unittests pass when we require context. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Possible asan fix. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/widget.h
diff --git a/ui/views/widget/widget.h b/ui/views/widget/widget.h
index 0eaa78add914fe16b3be681c40b92fe7e32057e1..ac98e763dd0cb1afd2c748fad3fb95d07f181c3a 100644
--- a/ui/views/widget/widget.h
+++ b/ui/views/widget/widget.h
@@ -207,12 +207,20 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
Widget();
virtual ~Widget();
- // Creates a decorated window Widget with the specified properties.
+ // Creates a toplevel window with no context. These methods should only be
+ // used in cases where there is no contextual information because we're
+ // creating a toplevel window connected to no other event.
+ //
+ // If you have any parenting or context information, or can pass that
+ // information, prefer the WithParent or WithContext versions of these
+ // methods.
static Widget* CreateWindow(WidgetDelegate* delegate);
Ben Goodger (Google) 2013/01/09 17:30:22 you need to align the function order in the .cc to
- static Widget* CreateWindowWithParent(WidgetDelegate* delegate,
- gfx::NativeWindow parent);
static Widget* CreateWindowWithBounds(WidgetDelegate* delegate,
const gfx::Rect& bounds);
+
+ // Creates a decorated window Widget with the specified properties.
+ static Widget* CreateWindowWithParent(WidgetDelegate* delegate,
+ gfx::NativeWindow parent);
static Widget* CreateWindowWithParentAndBounds(WidgetDelegate* delegate,
gfx::NativeWindow parent,
const gfx::Rect& bounds);
« ash/drag_drop/drag_image_view.h ('K') | « ui/views/controls/table/table_view_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698