chrome/browser/ui/views/extensions/native_app_window_views.cc - Issue 11801027: More work to make ash_unittests pass when we require context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/native_app_window_views.cc

Issue 11801027: More work to make ash_unittests pass when we require context. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Possible asan fix. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/native_app_window_views.cc

diff --git a/chrome/browser/ui/views/extensions/native_app_window_views.cc b/chrome/browser/ui/views/extensions/native_app_window_views.cc

index e84b7ac0321ffe19ba6e04e0eb563507d3576d9b..251cd996bb5dbceff3abd698e1800c00c532676d 100644

--- a/chrome/browser/ui/views/extensions/native_app_window_views.cc

+++ b/chrome/browser/ui/views/extensions/native_app_window_views.cc

@@ -77,6 +77,9 @@ void NativeAppWindowViews::InitializeDefaultWindow(

init_params.delegate = this;

init_params.remove_standard_frame = true;

init_params.use_system_default_icon = true;

+ // TODO(erg): Conceptually, these are toplevel windows, but we theoretically

+ // could plumb context through to here in some cases.

+ init_params.top_level = true;

window_->Init(init_params);

gfx::Rect window_bounds = create_params.bounds;

window_bounds.Inset(-GetFrameInsets());