tools/telemetry/telemetry/desktop_browser_backend.py - Issue 11801024: Fixed browser crash when using Debug build:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/desktop_browser_backend.py

Issue 11801024: Fixed browser crash when using Debug build: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Separates chrome.benchmarking.closeConnections() in order to remove --enable-benchmarking from tele… Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/desktop_browser_backend.py

diff --git a/tools/telemetry/telemetry/desktop_browser_backend.py b/tools/telemetry/telemetry/desktop_browser_backend.py

index 43ac0b5c1588aa830486a146afd33c6a873e14d1..59d63cb0bebd7d796f58da5348e35ca886e015aa 100644

--- a/tools/telemetry/telemetry/desktop_browser_backend.py

+++ b/tools/telemetry/telemetry/desktop_browser_backend.py

@@ -48,7 +48,6 @@ class DesktopBrowserBackend(browser_backend.BrowserBackend):

args = super(DesktopBrowserBackend, self).GetBrowserStartupArgs()

args.append('--remote-debugging-port=%i' % self._port)

args.append('--window-size=1280,1024')

- args.append('--enable-benchmarking')

tonyg 2013/01/24 22:00:29 We run telemetry on older builds called reference

Danh Nguyen 2013/02/07 16:56:32 Done. Added code to detect chrome branch number so

if not self.options.dont_override_profile:

self._tmpdir = tempfile.mkdtemp()

args.append('--user-data-dir=%s' % self._tmpdir)