Cleanups.

runtime/lib/double.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <math.h>
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/double_conversion.h"
@@ skipping 54 matching lines @@
   double left = Double::CheckedHandle(arguments->NativeArgAt(0)).value();
   GET_NON_NULL_NATIVE_ARGUMENT(Double, right_object, arguments->NativeArgAt(1));
   double right = right_object.value();
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Double_div %f / %f\n", left, right);
   }
   return Double::New(left / right);
 }
 
 
+static RawInteger* DoubleToInteger(double val, const char* error_msg) {
+  if (isinf(val) || isnan(val)) {
+    const Array& args = Array::Handle(Array::New(1));
+    args.SetAt(0, String::Handle(String::New(error_msg)));
+    Exceptions::ThrowByType(Exceptions::kUnsupported, args);
+  }
+  if ((Smi::kMinValue <= val) && (val <= Smi::kMaxValue)) {
+    return Smi::New(static_cast<intptr_t>(val));
+  } else if ((Mint::kMinValue <= val) && (val <= Mint::kMaxValue)) {
+    return Mint::New(static_cast<int64_t>(val));
+  } else {
+    return BigintOperations::NewFromDouble(val);
+  }
+}
+
 DEFINE_NATIVE_ENTRY(Double_trunc_div, 2) {
   double left = Double::CheckedHandle(arguments->NativeArgAt(0)).value();
   GET_NON_NULL_NATIVE_ARGUMENT(Double, right_object, arguments->NativeArgAt(1));
   double right = right_object.value();
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Double_trunc_div %f ~/ %f\n", left, right);
   }
-  double result = trunc(left / right);
-  if (isinf(result) || isnan(result)) {
-    const Array& args = Array::Handle(Array::New(1));
-    args.SetAt(0, String::Handle(String::New(
-        "Result of truncating division is Infinity or NaN")));
-    Exceptions::ThrowByType(Exceptions::kUnsupported, args);
-  }
-  if ((Smi::kMinValue <= result) && (result <= Smi::kMaxValue)) {
-    return Smi::New(static_cast<intptr_t>(result));
-  } else if ((Mint::kMinValue <= result) && (result <= Mint::kMaxValue)) {
-    return Mint::New(static_cast<int64_t>(result));
-  } else {
-    return BigintOperations::NewFromDouble(result);
-  }
+  return DoubleToInteger(trunc(left / right),
+                         "Result of truncating division is Infinity or NaN");
 }
 
 
 DEFINE_NATIVE_ENTRY(Double_modulo, 2) {
   double left = Double::CheckedHandle(arguments->NativeArgAt(0)).value();
   GET_NON_NULL_NATIVE_ARGUMENT(Double, right_object, arguments->NativeArgAt(1));
   double right = right_object.value();
 
   double remainder = fmod_ieee(left, right);
   if (remainder == 0.0) {
@@ skipping 88 matching lines @@
 }
 
 
 #if defined(TARGET_OS_MACOS)
 // MAC OSX math library produces old style cast warning.
 #pragma GCC diagnostic ignored "-Wold-style-cast"
 #endif
 
 DEFINE_NATIVE_ENTRY(Double_toInt, 1) {
   const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
-  if (isinf(arg.value()) || isnan(arg.value())) {
-    const Array& args = Array::Handle(Array::New(1));
-    args.SetAt(0, String::Handle(String::New("Infinity or NaN toInt")));
-    Exceptions::ThrowByType(Exceptions::kUnsupported, args);
-  }
-  double result = trunc(arg.value());
-  if ((Smi::kMinValue <= result) && (result <= Smi::kMaxValue)) {
-    return Smi::New(static_cast<intptr_t>(result));
-  } else if ((Mint::kMinValue <= result) && (result <= Mint::kMaxValue)) {
-    return Mint::New(static_cast<int64_t>(result));
-  } else {
-    return BigintOperations::NewFromDouble(result);
-  }
+  return DoubleToInteger(arg.value(), "Infinity or NaN toInt");
 }
 
 
 DEFINE_NATIVE_ENTRY(Double_parse, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(String, value, arguments->NativeArgAt(0));
   Scanner scanner(value, Symbols::Empty());
   const Scanner::GrowableTokenStream& tokens = scanner.GetStream();
   String* number_string;
   bool is_positive;
   if (Scanner::IsValidLiteral(tokens,
@@ skipping 115 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Double_getIsNegative, 1) {
   const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
   // Include negative zero, infinity.
   return Bool::Get(signbit(arg.value()) && !isnan(arg.value()));
 }
 
 // Add here only functions using/referring to old-style casts.
 
 }  // namespace dart