Allow dragging a download only after the download is complete.

Allow dragging a download only after the download is complete.

This was already the case on views and cocoa. However GTK was allowing a drag
after the large icon finishes loading. This CL also updates callers to
use GetTargetFilePath() on the DownloadItem instead of GetFullPath().
For a completed download, both methods are equivalent, but we prefer
the former as it is clear that the path being requested is the final
target path.

BUG=116551
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176159

[asanka, 2013-01-08 23:22:02]

estade: chrome/browser/ui/gtk
  The functional change is to delay calling DownloadItemDrag::SetSource until
the download completes.

thakis: chrome/browser/ui/cocoa
  Updated to use DI::GetTargetFilePath().

benjhayden: chrome/browser/ui/webui
  Updated to not call DragDownload until the download is complete.

[Nico, 2013-01-09 06:19:46]

cocoa lgtm

[benjhayden, 2013-01-09 18:41:52]

lgtm

[Evan Stade, 2013-01-09 22:35:51]

gtk lgtm

[asanka, 2013-01-09 23:46:47]

Thanks!

hashimoto: OWNER check for chrome/browser/chromeos/drive?

[hashimoto, 2013-01-10 03:59:06]

lgtm

[commit-bot: I haz the power, 2013-01-10 16:24:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/11801022/5001

[commit-bot: I haz the power, 2013-01-10 16:24:30]

Failed to apply patch for chrome/browser/ui/gtk/download/download_item_gtk.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/gtk/download/download_item_gtk.cc
  Hunk #1 FAILED at 461.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/gtk/download/download_item_gtk.cc.rej

Patch:       chrome/browser/ui/gtk/download/download_item_gtk.cc
Index: chrome/browser/ui/gtk/download/download_item_gtk.cc
diff --git a/chrome/browser/ui/gtk/download/download_item_gtk.cc
b/chrome/browser/ui/gtk/download/download_item_gtk.cc
index
89ca90c54fb97b7ce9bee45f0c0f8d116b17459a..6abc291ac41c56cfa8721f2a93974d8e42764f75
100644
--- a/chrome/browser/ui/gtk/download/download_item_gtk.cc
+++ b/chrome/browser/ui/gtk/download/download_item_gtk.cc
@@ -461,7 +461,10 @@ void DownloadItemGtk::OnLoadSmallIconComplete(gfx::Image*
image) {
 
 void DownloadItemGtk::OnLoadLargeIconComplete(gfx::Image* image) {
   icon_large_ = image;
-  DownloadItemDrag::SetSource(body_.get(), get_download(), icon_large_);
+  if (get_download()->IsComplete())
+    DownloadItemDrag::SetSource(body_.get(), get_download(), icon_large_);
+  // Else, the download will be made draggable once an OnDownloadUpdated()
+  // notification is received with download->IsComplete().
 }
 
 void DownloadItemGtk::LoadIcon() {

[commit-bot: I haz the power, 2013-01-10 19:46:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/11801022/16001

[commit-bot: I haz the power, 2013-01-10 21:30:40]

Change committed as 176159