[Android] Break GTest emulator launching into a separate function.

[Android] Break GTest emulator launching into a separate function.

BUG=167331
TEST=run_tests.py -v -e -n 2

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175894

[frankf, 2013-01-07 18:27:22]

LGTM with nit/suggestion.

https://codereview.chromium.org/11801016/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

https://codereview.chromium.org/11801016/diff/1/build/android/run_tests.py#ne...
build/android/run_tests.py:110: def LaunchEmulators(emulator_count,
fast_and_loose=False):
I recall fast_and_loose option causing more harm than good. Can you track what
it actually does and whether we can remove it in a separate CL.

https://codereview.chromium.org/11801016/diff/1/build/android/run_tests.py#ne...
build/android/run_tests.py:126: emu = emulator.Emulator(avd_name,
fast_and_loose)
Is there any kind of logging done by the emulator module? If not, maybe output
something at info level.

[craigdh, 2013-01-07 22:50:41]

https://codereview.chromium.org/11801016/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

https://codereview.chromium.org/11801016/diff/1/build/android/run_tests.py#ne...
build/android/run_tests.py:110: def LaunchEmulators(emulator_count,
fast_and_loose=False):
On 2013/01/07 18:27:23, frankf wrote:
> I recall fast_and_loose option causing more harm than good. Can you track what
> it actually does and whether we can remove it in a separate CL. 

Filed http://crbug.com/168653 and assigned it to myself.

https://codereview.chromium.org/11801016/diff/1/build/android/run_tests.py#ne...
build/android/run_tests.py:126: emu = emulator.Emulator(avd_name,
fast_and_loose)
On 2013/01/07 18:27:23, frankf wrote:
> Is there any kind of logging done by the emulator module? If not, maybe output
> something at info level.

The emulator module logs at the info level already, but I'll  add something here
as well.

[frankf, 2013-01-07 23:13:07]

One more nit.

https://codereview.chromium.org/11801016/diff/5001/build/android/run_tests.py
File build/android/run_tests.py (right):

https://codereview.chromium.org/11801016/diff/5001/build/android/run_tests.py...
build/android/run_tests.py:110: def LaunchEmulators(emulator_count,
fast_and_loose=False):
if this is private to the module, prefix with underscore.

[craigdh, 2013-01-07 23:46:14]

https://codereview.chromium.org/11801016/diff/5001/build/android/run_tests.py
File build/android/run_tests.py (right):

https://codereview.chromium.org/11801016/diff/5001/build/android/run_tests.py...
build/android/run_tests.py:110: def LaunchEmulators(emulator_count,
fast_and_loose=False):
On 2013/01/07 23:13:07, frankf wrote:
> if this is private to the module, prefix with underscore.

Moved to emulator.py so it can be reused.

[frankf, 2013-01-08 22:14:27]

https://codereview.chromium.org/11801016/diff/8001/build/android/emulator.py
File build/android/emulator.py (right):

https://codereview.chromium.org/11801016/diff/8001/build/android/emulator.py#...
build/android/emulator.py:345: Emulator(None, True).Launch(True)
Can we move emulator.py into pylib/utils. Does it make sense  this script to be
executable? If so maybe just have a thin executable wrapper around
utils/emulator.py here.

[frankf, 2013-01-08 22:15:35]

cc navabi who is looking into emulators.

[craigdh, 2013-01-08 22:53:13]

On 2013/01/08 22:14:27, frankf wrote:
> https://codereview.chromium.org/11801016/diff/8001/build/android/emulator.py
> File build/android/emulator.py (right):
> 
>
https://codereview.chromium.org/11801016/diff/8001/build/android/emulator.py#...
> build/android/emulator.py:345: Emulator(None, True).Launch(True)
> Can we move emulator.py into pylib/utils. Does it make sense  this script to
be
> executable? If so maybe just have a thin executable wrapper around
> utils/emulator.py here.

sgtm. AFAICT run_tests.py is the only consumer of emulator.py.

[craigdh, 2013-01-09 01:32:48]

Moved emulator logic to emulator.py in pylib/utils. The original script is now
just a small wrapper. PTAL.

https://codereview.chromium.org/11801016/diff/6003/build/android/pylib/utils/...
File build/android/pylib/utils/emulator.py (right):

https://codereview.chromium.org/11801016/diff/6003/build/android/pylib/utils/...
build/android/pylib/utils/emulator.py:120: emulator = Emulator(avd_name, False)
The fast_and_loose option will be removed before this lands, at which point I'll
rebase and remove the second argument.

[frankf, 2013-01-09 01:38:54]

lgtm. Thanks Craig.