Fix PromoResourceServiceTest.NotificationPromoTest and make it use dynamic [future] dates.

Fix PromoResourceServiceTest.NotificationPromoTest and make it use dynamic [future] dates.

R=rsesek@chromium.org
BUG=168561
TEST=PromoResourceServiceTest.NotificationPromoTest passes after Jan 7 2013 5:40:75 PST

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175428

[jochen (gone - plz use gerrit), 2013-01-07 18:26:22]

https://codereview.chromium.org/11801015/diff/1/chrome/browser/web_resource/p...
File chrome/browser/web_resource/promo_resource_service_unittest.cc (right):

https://codereview.chromium.org/11801015/diff/1/chrome/browser/web_resource/p...
chrome/browser/web_resource/promo_resource_service_unittest.cc:38: status);
this will construct a localized formatter, won't it? What about forcing the
locale to en-US?

[Dan Beam, 2013-01-07 18:32:42]

https://codereview.chromium.org/11801015/diff/1/chrome/browser/web_resource/p...
File chrome/browser/web_resource/promo_resource_service_unittest.cc (right):

https://codereview.chromium.org/11801015/diff/1/chrome/browser/web_resource/p...
chrome/browser/web_resource/promo_resource_service_unittest.cc:38: status);
On 2013/01/07 18:26:22, jochen wrote:
> this will construct a localized formatter, won't it? What about forcing the
> locale to en-US?

Done.

[jochen (gone - plz use gerrit), 2013-01-07 18:36:13]

lgtm, thx

[Robert Sesek, 2013-01-07 19:58:46]

LGTM

https://chromiumcodereview.appspot.com/11801015/diff/4001/chrome/browser/web_...
File chrome/browser/web_resource/promo_resource_service_unittest.cc (right):

https://chromiumcodereview.appspot.com/11801015/diff/4001/chrome/browser/web_...
chrome/browser/web_resource/promo_resource_service_unittest.cc:33: const char*
kDateFormat = "dd MMM yyyy HH:mm:ss zzz";
const char* -> const char kDateFormat[] removes a static initializer.

Not that it matters for test code, though

[Dan Beam, 2013-01-07 20:13:22]

https://chromiumcodereview.appspot.com/11801015/diff/4001/chrome/browser/web_...
File chrome/browser/web_resource/promo_resource_service_unittest.cc (right):

https://chromiumcodereview.appspot.com/11801015/diff/4001/chrome/browser/web_...
chrome/browser/web_resource/promo_resource_service_unittest.cc:33: const char*
kDateFormat = "dd MMM yyyy HH:mm:ss zzz";
On 2013/01/07 19:58:46, rsesek wrote:
> const char* -> const char kDateFormat[] removes a static initializer.
> 
> Not that it matters for test code, though

Done.

[commit-bot: I haz the power, 2013-01-07 20:14:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11801015/9001

[commit-bot: I haz the power, 2013-01-07 22:38:33]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[achuithb, 2013-01-08 21:44:36]

https://codereview.chromium.org/11801015/diff/9001/chrome/browser/web_resourc...
File chrome/browser/web_resource/promo_resource_service_unittest.cc (right):

https://codereview.chromium.org/11801015/diff/9001/chrome/browser/web_resourc...
chrome/browser/web_resource/promo_resource_service_unittest.cc:35:
std::pair<double, std::string> YearFromNow() {
Please add a function comment explaining the return value. FWIW, it's more
common to use out args for this kind of thing:
void GetYearFromNow(double* year, std::string* date_string);

This would also make the calling code more readable - year_from_now.first and
year_from_now.second are a little cryptic.