Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: test/cctest/test-api-interceptors.cc

Issue 1180073002: Introduce DefineOwnPropertyIgnoreAttributes and make it call SetPropertyWithInterceptor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api-interceptors.cc
diff --git a/test/cctest/test-api-interceptors.cc b/test/cctest/test-api-interceptors.cc
index f0f817ffc151893c0c5b31d4d0bfbcfd73a5a548..a3ae095ba6f72e9e2d3e7e57db69341f261a9c15 100644
--- a/test/cctest/test-api-interceptors.cc
+++ b/test/cctest/test-api-interceptors.cc
@@ -1927,7 +1927,8 @@ static void PDeleter(Local<Name> name,
return; // not intercepted
}
- info.GetReturnValue().Set(false); // intercepted, don't delete the property
+ // cannot be intercepted, the property isn't handled by the interceptor.
+ info.GetReturnValue().Set(false);
}
@@ -1937,7 +1938,8 @@ static void IDeleter(uint32_t index,
return; // not intercepted
}
- info.GetReturnValue().Set(false); // intercepted, don't delete the property
+ // cannot be intercepted, the property isn't handled by the interceptor.
+ info.GetReturnValue().Set(false);
}
@@ -1956,13 +1958,13 @@ THREADED_TEST(Deleter) {
"k.bar = 'bar';"
"k[2] = 2;"
"k[4] = 4;");
- CHECK(v8_compile("delete k.foo")->Run()->IsFalse());
+ CHECK(v8_compile("delete k.foo")->Run()->IsTrue());
CHECK(v8_compile("delete k.bar")->Run()->IsTrue());
CHECK(v8_compile("k.foo")->Run()->Equals(v8_str("foo")));
CHECK(v8_compile("k.bar")->Run()->IsUndefined());
- CHECK(v8_compile("delete k[2]")->Run()->IsFalse());
+ CHECK(v8_compile("delete k[2]")->Run()->IsTrue());
CHECK(v8_compile("delete k[4]")->Run()->IsTrue());
CHECK(v8_compile("k[2]")->Run()->Equals(v8_num(2)));
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698