Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1180073002: Introduce DefineOwnPropertyIgnoreAttributes and make it call SetPropertyWithInterceptor (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce DefineOwnPropertyIgnoreAttributes and make it call SetPropertyWithInterceptor. Otherwise using Object.defineProperty with window.localStorage will not actually store the value into the database but on the object itself. BUG=v8:4137 LOG=n Committed: https://crrev.com/fa3e6c0850bebbe38a245896e5889384b4bbfd8d Cr-Commit-Position: refs/heads/master@{#29002}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Fixes #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 1

Patch Set 9 : Rebased and addressed comments #

Patch Set 10 : #

Patch Set 11 : Revert HIDDEN to OWN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -152 lines) Patch
M src/api.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M src/json-parser.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 3 chunks +9 lines, -8 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 10 9 chunks +128 lines, -123 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -16 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Toon Verwaest
ptal @jochen: fyi
5 years, 6 months ago (2015-06-12 09:35:34 UTC) #2
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/1180073002/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1180073002/diff/20001/src/objects.cc#newcode5093 src/objects.cc:5093: Spurious change.
5 years, 6 months ago (2015-06-12 10:05:25 UTC) #3
Toon Verwaest
ptal again, the code changed entirely.
5 years, 6 months ago (2015-06-12 10:57:44 UTC) #4
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/1180073002/diff/140001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1180073002/diff/140001/src/objects.cc#newcode4216 src/objects.cc:4216: if (is_observed) { Please pull ...
5 years, 6 months ago (2015-06-12 12:53:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180073002/220001
5 years, 6 months ago (2015-06-12 13:49:20 UTC) #9
commit-bot: I haz the power
Committed patchset #11 (id:220001)
5 years, 6 months ago (2015-06-12 14:14:03 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 14:14:22 UTC) #11
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/fa3e6c0850bebbe38a245896e5889384b4bbfd8d
Cr-Commit-Position: refs/heads/master@{#29002}

Powered by Google App Engine
This is Rietveld 408576698