Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1180043004: Revert of Add script context with context-allocated "const this" (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev, Yang, Michael Starzinger, Dmitry Lomov (no reviews), arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add script context with context-allocated "const this" (patchset #7 id:120001 of https://codereview.chromium.org/1179893002/) Reason for revert: [Sheriff] Breaks gc mole: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/2435 Original issue's description: > Add script context with context-allocated "const this" > > R=rossberg@chromium.org > LOG=N > BUG=498811 > > Committed: https://crrev.com/fa32d461c16a053cc6d48d3fb326016bc2765765 > Cr-Commit-Position: refs/heads/master@{#28988} TBR=rossberg@chromium.org,mstarzinger@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498811 Committed: https://crrev.com/32e6455c1ab79bbfdcc51acaa57fe5fac6e7c8bb Cr-Commit-Position: refs/heads/master@{#28992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -270 lines) Patch
M src/arm/full-codegen-arm.cc View 6 chunks +23 lines, -15 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 5 chunks +18 lines, -13 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +0 lines, -41 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +29 lines, -12 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 5 chunks +23 lines, -15 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 6 chunks +22 lines, -14 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/full-codegen-ppc.cc View 6 chunks +22 lines, -15 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 4 chunks +21 lines, -20 lines 0 comments Download
M src/scopeinfo.cc View 2 chunks +0 lines, -72 lines 0 comments Download
M src/scopes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/snapshot-common.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/variables.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 6 chunks +15 lines, -9 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Add script context with context-allocated "const this"
5 years, 6 months ago (2015-06-12 10:07:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180043004/1
5 years, 6 months ago (2015-06-12 10:07:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 10:07:28 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 10:07:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32e6455c1ab79bbfdcc51acaa57fe5fac6e7c8bb
Cr-Commit-Position: refs/heads/master@{#28992}

Powered by Google App Engine
This is Rietveld 408576698