Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1180043003: External snapshot: allow empty snapshot for external snapshot. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
vogelheim
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

External snapshot: allow empty snapshot for external snapshot. R=vogelheim@chromium.org Committed: https://crrev.com/dd96c47a8162b4456c12b7b96e48e46c559b06b1 Cr-Commit-Position: refs/heads/master@{#28989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/snapshot/snapshot.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 6 months ago (2015-06-12 08:19:34 UTC) #1
vogelheim
lgtm
5 years, 6 months ago (2015-06-12 08:20:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180043003/1
5 years, 6 months ago (2015-06-12 08:20:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 09:37:03 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 09:37:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd96c47a8162b4456c12b7b96e48e46c559b06b1
Cr-Commit-Position: refs/heads/master@{#28989}

Powered by Google App Engine
This is Rietveld 408576698