Issue 1180043002: [heap] All immutable roots are either smis or immovable heap objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1180043002: [heap] All immutable roots are either smis or immovable heap objects. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer

Modified:
5 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[heap] All immutable roots are either smis or immovable heap objects. R=yangguo@chromium.org

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/heap/heap.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Benedikt Meurer

Hey Yang, This is the change we've talked about. Please take a look. Thanks, Benedikt

5 years, 6 months ago (2015-06-12 07:05:18 UTC) #2

Yang

On 2015/06/12 07:05:18, Benedikt Meurer wrote: > Hey Yang, > > This is the change ...

5 years, 6 months ago (2015-06-12 07:06:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180043002/1

5 years, 6 months ago (2015-06-12 07:06:59 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-12 07:20:41 UTC) #7

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages