Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2106)

Unified Diff: Source/wtf/ArrayBufferView.h

Issue 1180023002: Inline the only callers of TypedArrayBase::{setRange,zeroRange} (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/wtf/ArrayBufferView.h
diff --git a/Source/wtf/ArrayBufferView.h b/Source/wtf/ArrayBufferView.h
index 09125cc9adb21654438880f225cdd310490b2b22..1264f34cb63ec6b2ce0f1df33b83626708956dfd 100644
--- a/Source/wtf/ArrayBufferView.h
+++ b/Source/wtf/ArrayBufferView.h
@@ -80,10 +80,6 @@ class WTF_EXPORT ArrayBufferView : public RefCounted<ArrayBufferView> {
inline bool setImpl(ArrayBufferView*, unsigned byteOffset);
- inline bool setRangeImpl(const char* data, size_t dataByteLength, unsigned byteOffset);
-
- inline bool zeroRangeImpl(unsigned byteOffset, size_t rangeByteLength);
-
// Helper to verify that a given sub-range of an ArrayBuffer is
// within range.
template <typename T>
@@ -132,34 +128,6 @@ bool ArrayBufferView::setImpl(ArrayBufferView* array, unsigned byteOffset)
return true;
}
-bool ArrayBufferView::setRangeImpl(const char* data, size_t dataByteLength, unsigned byteOffset)
-{
- if (byteOffset > byteLength()
- || byteOffset + dataByteLength > byteLength()
- || byteOffset + dataByteLength < byteOffset) {
- // Out of range offset or overflow
- return false;
- }
-
- char* base = static_cast<char*>(baseAddress());
- memmove(base + byteOffset, data, dataByteLength);
- return true;
-}
-
-bool ArrayBufferView::zeroRangeImpl(unsigned byteOffset, size_t rangeByteLength)
-{
- if (byteOffset > byteLength()
- || byteOffset + rangeByteLength > byteLength()
- || byteOffset + rangeByteLength < byteOffset) {
- // Out of range offset or overflow
- return false;
- }
-
- char* base = static_cast<char*>(baseAddress());
- memset(base + byteOffset, 0, rangeByteLength);
- return true;
-}
-
} // namespace WTF
using WTF::ArrayBufferView;

Powered by Google App Engine
This is Rietveld 408576698