Inline the only callers of TypedArrayBase::{setRange,zeroRange}

Source/modules/webaudio/AudioBuffer.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 158 matching lines @@
     unsigned numberOfChannels = bus->numberOfChannels();
     m_channels.reserveCapacity(numberOfChannels);
     for (unsigned i = 0; i < numberOfChannels; ++i) {
         RefPtr<DOMFloat32Array> channelDataArray = createFloat32ArrayOrNull(m_length);
         // If the channel data array could not be created, just return. The caller will need to
         // check that the desired number of channels were created.
         if (!channelDataArray)
             return;
 
         channelDataArray->setNeuterable(false);
-        channelDataArray->setRange(bus->channel(i)->data(), m_length, 0);
+        const float* src = bus->channel(i)->data();
+        float* dst = channelDataArray->data();
+        memmove(dst, src, m_length * sizeof(*dst));

[adamk, 2015/06/12 17:59:25]

For WebAudio reviewers: this memmove is from the original, generic code. I
suspect this could be memcpy here, though I also don't know how important perf
is here.

[Raymond Toy, 2015/06/12 18:05:50]

If the original did this, I'm happy with leaving it as is.

Also, the original had some checks on the parameters.  I think these checks
should be here. (Unless we know the checks will always pass. I didn't look at
that.)

[adamk, 2015/06/12 18:14:28]

The destination of this memmove was just created with size m_length, so this is
safe. I could make it look safer by calling
channelDataArray->view()->byteLength() (which will do the same math internally
that I'm doing here). Would you prefer that?

         m_channels.append(channelDataArray);
     }
 }
 
 PassRefPtr<DOMFloat32Array> AudioBuffer::getChannelData(unsigned channelIndex, ExceptionState& exceptionState)
 {
     if (channelIndex >= m_channels.size()) {
         exceptionState.throwDOMException(IndexSizeError, "channel index (" + String::number(channelIndex) + ") exceeds number of channels (" + String::number(m_channels.size()) + ")");
         return nullptr;
     }
@@ skipping 120 matching lines @@
 
     ASSERT(src);
     ASSERT(dst);
 
     memcpy(dst + startInChannel, src, count * sizeof(*dst));
 }
 
 void AudioBuffer::zero()
 {
     for (unsigned i = 0; i < m_channels.size(); ++i) {
-        if (getChannelData(i))
-            getChannelData(i)->zeroRange(0, length());
+        if (DOMFloat32Array* array = getChannelData(i)) {
+            float* data = array->data();
+            memset(data, 0, length() * sizeof(*data));

[Raymond Toy, 2015/06/12 18:05:50]

The original had some checks on the parameters. Are we guaranteed we're safe
here?

[adamk, 2015/06/12 18:14:28]

Same as above, all the channel data arrays have the same length as m_len gth.
But I can make this look safer by calling byteLength() if you'd prefer.

+        }
     }
 }
 
 v8::Local<v8::Object> AudioBuffer::associateWithWrapper(v8::Isolate* isolate, const WrapperTypeInfo* wrapperType, v8::Local<v8::Object> wrapper)
 {
     ScriptWrappable::associateWithWrapper(isolate, wrapperType, wrapper);
 
     if (!wrapper.IsEmpty()) {
         // We only setDeallocationObservers on array buffers that are held by
         // some object in the V8 heap, not in the ArrayBuffer constructor
         // itself. This is because V8 GC only cares about memory it can free on
         // GC, and until the object is exposed to JavaScript, V8 GC doesn't
         // affect it.
         for (unsigned i = 0, n = numberOfChannels(); i < n; ++i) {
             getChannelData(i)->buffer()->setDeallocationObserver(DOMArrayBufferDeallocationObserver::instance());
         }
     }
     return wrapper;
 }
 
 } // namespace blink
 
 #endif // ENABLE(WEB_AUDIO)