Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1180013002: Disable SitePerProcess tests that are incompatible with Blink fix. (Closed)

Created:
5 years, 6 months ago by Charlie Reis
Modified:
5 years, 6 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable SitePerProcess tests that are incompatible with Blink fix. These will be updated and re-enabled once the first real commit type for subframes in Blink is fixed. BUG=498559 TEST=Tree stays green after https://codereview.chromium.org/1173513002/. Committed: https://crrev.com/b220cf91b8e8c094a2a81b5fb826f809aac9bf21 Cr-Commit-Position: refs/heads/master@{#334087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M content/browser/site_per_process_browsertest.cc View 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Charlie Reis
Nasko, can you take a look? I'll get these re-enabled after the Blink fix lands.
5 years, 6 months ago (2015-06-11 23:29:24 UTC) #2
nasko
LGTM
5 years, 6 months ago (2015-06-11 23:30:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180013002/1
5 years, 6 months ago (2015-06-11 23:30:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-11 23:54:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180013002/1
5 years, 6 months ago (2015-06-11 23:55:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 00:00:43 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b220cf91b8e8c094a2a81b5fb826f809aac9bf21 Cr-Commit-Position: refs/heads/master@{#334087}
5 years, 6 months ago (2015-06-12 00:01:41 UTC) #11
Charlie Reis
5 years, 6 months ago (2015-06-15 16:29:43 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1185833003/ by creis@chromium.org.

The reason for reverting is: These should pass now that
https://codereview.chromium.org/1173513002/ and
https://codereview.chromium.org/1143653002/ have landed..

Powered by Google App Engine
This is Rietveld 408576698