Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tools/testing/dart/browser_test.dart

Issue 11800002: "Reverting 16675-16676, 71-73" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/test.dart ('k') | tools/testing/dart/http_server.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of test_suite; 5 part of test_suite;
6 6
7 String getHtmlContents(String title, 7 String getHtmlContents(String title,
8 Path controllerScript, 8 Path controllerScript,
9 Path dartJsScript, 9 Path dartJsScript,
10 String scriptType, 10 String scriptType,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 </body> 47 </body>
48 </html> 48 </html>
49 """; 49 """;
50 50
51 String wrapDartTestInLibrary(Path test) => 51 String wrapDartTestInLibrary(Path test) =>
52 """ 52 """
53 library libraryWrapper; 53 library libraryWrapper;
54 part '$test'; 54 part '$test';
55 """; 55 """;
56 56
57 String dartTestWrapper(Path dartHome, String testPath, Path library) { 57 String dartTestWrapper(Path dartHome, Path library) {
58 var testPathDir = pathLib.dirname(testPath);
59 var dartHomePath = dartHome.toString();
60 var unitTest = pathLib.relative(pathLib.join(dartHomePath,
61 'pkg/unittest/lib'), from: testPathDir);
62
63 var libString = library.toString();
64 if (!pathLib.isAbsolute(libString)) {
65 libString = pathLib.join(dartHome.toString(), libString);
66 }
67 // Tests inside "pkg" import unittest using "package:". All others use a 58 // Tests inside "pkg" import unittest using "package:". All others use a
68 // relative path. The imports need to agree, so use a matching form here. 59 // relative path. The imports need to agree, so use a matching form here.
69 if (pathLib.relative(libString, from: dartHome.toString()).contains("pkg")) { 60 var unitTest = dartHome.append("pkg/unittest/lib").toString();
61
62 // TODO(rnystrom): Looking in the entire path here is wrong. It should only
63 // consider the relative path within dartHome. Unfortunately,
64 // Path.relativeTo() does not handle cases where library is already a relative
65 // path, and Path.isAbsolute does not work on Windows.
66 if (library.segments().contains("pkg")) {
70 unitTest = 'package:unittest'; 67 unitTest = 'package:unittest';
71 } 68 }
69
72 return """ 70 return """
73 library test; 71 library test;
74 72
75 import '$unitTest/unittest.dart' as unittest; 73 import '$unitTest/unittest.dart' as unittest;
76 import '$unitTest/html_config.dart' as config; 74 import '$unitTest/html_config.dart' as config;
77 import '${pathLib.relative(libString, from: testPathDir)}' as Test; 75 import '${library}' as Test;
78 76
79 main() { 77 main() {
80 config.useHtmlConfiguration(); 78 config.useHtmlConfiguration();
81 unittest.group('', Test.main); 79 unittest.group('', Test.main);
82 } 80 }
83 """; 81 """;
84 } 82 }
OLDNEW
« no previous file with comments | « tools/test.dart ('k') | tools/testing/dart/http_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698