src/objects.cc - Issue 1179983002: Remove bogus ASSERT, this method can handle ExternalArrays just fine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1179983002: Remove bogus ASSERT, this method can handle ExternalArrays just fine. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index edd758370bdb76f490e24e16b162b2f9ee98b9ff..86fb22ae36f8535a2e237b5cf93a1a8594ab2498 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -4276,7 +4276,6 @@ MaybeHandle<Object> JSObject::SetOwnPropertyIgnoreAttributes(

MaybeHandle<Object> JSObject::SetOwnElementIgnoreAttributes(

Handle<JSObject> object, uint32_t index, Handle<Object> value,

PropertyAttributes attributes, ExecutableAccessorInfoHandling handling) {

- DCHECK(!object->HasExternalArrayElements());

Isolate* isolate = object->GetIsolate();

LookupIterator it(isolate, object, index,

LookupIterator::OWN_SKIP_INTERCEPTOR);

« no previous file with comments | « no previous file | no next file » | no next file with comments »