Issue 1179983002: Remove bogus ASSERT, this method can handle ExternalArrays just fine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179983002: Remove bogus ASSERT, this method can handle ExternalArrays just fine. (Closed)

Created:
5 years, 6 months ago by Toon Verwaest

Modified:
5 years, 6 months ago

Reviewers:
Igor Sheludko, arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/objects.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Toon Verwaest

5 years, 6 months ago (2015-06-11 20:46:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dd90d2d4da628e49cd4460241b39e41b6843054c (presubmit successful).