Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1179973004: Fix win style errors. (Closed)

Created:
5 years, 6 months ago by erikchen
Modified:
5 years, 6 months ago
Reviewers:
Tom Sepez, Nico
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix win style errors. Recently introduced at https://codereview.chromium.org/1180313007/. BUG=493414 TBR=tsepez Committed: https://crrev.com/f19538207d2f833192ea7e4ca367da91cdcc7a8b Cr-Commit-Position: refs/heads/master@{#334741}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments from thakis. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ipc/attachment_broker_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
erikchen
thakis: Please review. Note that the errors don't show up on my local win machine, ...
5 years, 6 months ago (2015-06-16 22:16:28 UTC) #2
Nico
Thanks! lgtm with the comment. One of the two errors was actually from https://codereview.chromium.org/1185133006 See ...
5 years, 6 months ago (2015-06-16 22:21:00 UTC) #3
erikchen
https://codereview.chromium.org/1179973004/diff/1/ipc/ipc_channel_win.h File ipc/ipc_channel_win.h (right): https://codereview.chromium.org/1179973004/diff/1/ipc/ipc_channel_win.h#newcode113 ipc/ipc_channel_win.h:113: base::WeakPtrFactory<ChannelWin> weak_factory_; On 2015/06/16 22:21:00, Nico wrote: > You'll ...
5 years, 6 months ago (2015-06-16 22:24:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179973004/10003
5 years, 6 months ago (2015-06-16 22:25:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/71412)
5 years, 6 months ago (2015-06-16 22:36:53 UTC) #9
Nico
+tsepez for ipc/owners
5 years, 6 months ago (2015-06-16 22:38:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179973004/10003
5 years, 6 months ago (2015-06-16 22:39:11 UTC) #13
Tom Sepez
lgtm
5 years, 6 months ago (2015-06-16 22:49:10 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:10003)
5 years, 6 months ago (2015-06-16 23:16:12 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 23:16:58 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f19538207d2f833192ea7e4ca367da91cdcc7a8b
Cr-Commit-Position: refs/heads/master@{#334741}

Powered by Google App Engine
This is Rietveld 408576698