Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 1179963002: bluetooth: Add DOMErrors in WebBluetooth Spec to WebBluetooth interface. (Closed)

Created:
4 years, 10 months ago by ortuno
Modified:
4 years, 10 months ago
Reviewers:
Jeffrey Yasskin, scheib
CC:
blink-reviews, dglazkov+blink, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@bluetooth-read-value-impl
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Add DOMErrors in WebBluetooth Spec to WebBluetooth interface. Errors added: - AbortError - InvalidModificationError - InvalidStateError - NotSupportedError - SyntaxError This is the first of two patches to add these errors to WebBluetooth: [1] This patch. [2] http://crrev.com/1181783002 BUG=499498, 499014, 499125 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M Source/modules/bluetooth/BluetoothError.cpp View 1 chunk +12 lines, -2 lines 0 comments Download
M public/platform/modules/bluetooth/WebBluetoothError.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
ortuno
@jyasskin: PTAL
4 years, 10 months ago (2015-06-11 19:52:11 UTC) #2
Jeffrey Yasskin
lgtm
4 years, 10 months ago (2015-06-11 19:57:17 UTC) #3
scheib
LGTM
4 years, 10 months ago (2015-06-11 22:08:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179963002/1
4 years, 10 months ago (2015-06-13 05:05:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197085
4 years, 10 months ago (2015-06-13 06:34:44 UTC) #8
domenic
Just a tip, DOMError is a very different and deprecated thing. The commit description here ...
4 years, 10 months ago (2015-06-16 15:27:26 UTC) #9
ortuno
4 years, 10 months ago (2015-06-16 16:34:56 UTC) #10
Message was sent while issue was closed.
On 2015/06/16 at 15:27:26, domenic wrote:
> Just a tip, DOMError is a very different and deprecated thing. The commit
description here was scary, but thankfully the code is DOMException.

Ah sorry my bad. Thanks for pointing it out!

Powered by Google App Engine
This is Rietveld 408576698