Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1179953006: [Merge to M44] Chromium changes to statically link ffmpeg. (Closed)

Created:
4 years ago by chcunningham
Modified:
4 years ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, hguihot+watch_chromium.org, yzshen+watch_chromium.org, stevenjb+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, grt+watch_chromium.org, lcwu+watch_chromium.org, chromoting-reviews_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, eme-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, hubbe+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, oshima+watch_chromium.org, kalyank, gunsch+watch_chromium.org, Michael Moss, darin (slow to review), hclam+watch_chromium.org, wfh+watch_chromium.org, avayvod+watch_chromium.org, asvitkine+watch_chromium.org, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

[Merge to M44] Chromium changes to statically link ffmpeg. Motivations: 1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs) 2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination 3. Simplifying media library initialization (Remove bool-ness, it just works) Licensing: We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits. TBR=thomasvl@chromium.org, dalecurtis@chromium.org, enne@chromium.org, grt@chromium.org, gunsch@chromium.org, isherman@chromium.org, jamiewalch@chromium.org, jochen@chromium.org, maruel@chromium.org, mmoss@google.com, phajdan.jr@chromium.org, sergeyu@chromium.org, sky@chromium.org BUG=435455, 429131, 441908 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Original Review URL: https://codereview.chromium.org/1141703002 (cherry picked from commit fd11b3c3aa6730ae1f024811b61913cd63f9d39a - refs/heads/master@{#333423}) Committed: https://chromium.googlesource.com/chromium/src/+/ab31fe6077d2ba3ede9a302d9ef4554363c9a939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -454 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_unittests.isolate View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/cc_unittests.isolate View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.isolate View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/common/installer.include View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/interactive_ui_tests.isolate View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/plugin/chrome_content_plugin_client.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/chromeos/autotest/files/client/deps/pyauto_dep/setup_test_links.sh View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/tools/build/mac/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/unit_tests.isolate View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chromecast/media/cma/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components_unittests.isolate View 4 chunks +0 lines, -4 lines 0 comments Download
M components/html_viewer/web_media_player_factory.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browsertests.isolate View 4 chunks +0 lines, -4 lines 0 comments Download
M content/content_gl_tests.isolate View 1 chunk +0 lines, -15 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M content/content_unittests.isolate View 4 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/test/content_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M media/base/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M media/base/media.h View 1 chunk +3 lines, -26 lines 0 comments Download
M media/base/media.cc View 1 chunk +17 lines, -43 lines 0 comments Download
D media/base/media_posix.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D media/base/media_stub.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D media/base/media_win.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M media/base/run_all_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast_unittests.isolate View 3 chunks +0 lines, -21 lines 0 comments Download
M media/cast/sender/audio_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/audio_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/sender.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M media/cast/test/simulator.cc View 1 chunk +1 line, -4 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M media/ffmpeg/ffmpeg_common_unittest.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M media/filters/ffmpeg_glue.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/media.gyp View 4 chunks +1 line, -5 lines 0 comments Download
M media/media_nacl.gyp View 2 chunks +3 lines, -1 line 0 comments Download
M media/media_unittests.isolate View 1 chunk +0 lines, -22 lines 0 comments Download
M media/mojo/services/renderer_config_default.cc View 1 chunk +1 line, -6 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/base/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/chromoting/chromoting_integration_tests.isolate View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
chcunningham
Merging back. Dale will commit since I can't :(.
4 years ago (2015-06-17 23:00:39 UTC) #2
DaleCurtis
4 years ago (2015-06-17 23:03:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab31fe6077d2ba3ede9a302d9ef4554363c9a939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698