components/history/core/browser/url_utils_unittest.cc - Issue 1179953005: Add History.TopHostsVisitsByRank UMA metric.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/url_utils_unittest.cc

Issue 1179953005: Add History.TopHostsVisitsByRank UMA metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@is_allowed

Patch Set: Use HistogramTester to eliminate test brittleness. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/url_utils_unittest.cc

diff --git a/components/history/core/browser/url_utils_unittest.cc b/components/history/core/browser/url_utils_unittest.cc

index 184bd66552fbf5a1c4c982001cf0ca8d1cb58a43..4f145c117df6749e89a5e58359382e635ccd4bd8 100644

--- a/components/history/core/browser/url_utils_unittest.cc

+++ b/components/history/core/browser/url_utils_unittest.cc

@@ -126,6 +126,12 @@ TEST(HistoryUrlUtilsTest, ToggleHTTPAndHTTPS) {

ToggleHTTPAndHTTPS(GURL("ftp://www.google.com/")));

}

+TEST(HistoryUrlUtilsTest, HostForTopHosts) {

+ EXPECT_EQ("foo.com", HostForTopHosts(GURL("https://foo.com/bar")));

+ EXPECT_EQ("foo.com", HostForTopHosts(GURL("http://foo.com:999/bar")));

+ EXPECT_EQ("foo.com", HostForTopHosts(GURL("http://www.foo.com/bar")));

} // namespace

} // namespace history