tools/metrics/histograms/histograms.xml - Issue 1179953005: Add History.TopHostsVisitsByRank UMA metric.

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1179953005: Add History.TopHostsVisitsByRank UMA metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@is_allowed

Patch Set: Add History.TopHostsVisitsByRank and extract HostForTopHosts util function. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 59310e105767ca3eebf87f350b0b988231a54dbd..4320b49067f4e212ca2beb5dea724ab85baa6a5a 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -12895,6 +12895,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="History.TopHostsVisitsByRank" units="rank">

+ <owner>twifkak@chromium.org</owner>

+ <summary>

+ Page visits to each of a user's top 50 hosts. Visits to all other hosts go

Mark P 2015/06/12 20:08:59 What happens if hosts get reordered? I visit host

twifkak 2015/06/12 20:43:46 Done.

+ into the 51st bucket. Only count the page visit if it came from user

+ browsing and only count it once when cycling through a redirect chain.

Mark P 2015/06/12 20:08:59 "if it came from user browsing" as opposed to what

twifkak 2015/06/12 20:43:46 I'm not sure to what it's referring exactly; I jus

+ </summary>

+</histogram>

<owner>Please list the metric's owners. Add more owner tags as needed.</owner>

@@ -12923,18 +12932,6 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

-<histogram name="History.TopSitesVisitsByRank" units="rank">

Mark P 2015/06/12 20:08:59 Do not delete old histograms.

twifkak 2015/06/12 20:43:46 Done.

- <obsolete>

- Deprecated as of 11/2014.

- </obsolete>

- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>

- <summary>

- Page visits to each of a user's top 50 sites. Visits to all other sites go

- into the 51st bucket. Only count the page visit if it came from user

- browsing and only count it once when cycling through a redirect chain.

- </summary>

-</histogram>

Deprecated because only the execution time at startup is of interest. See

« no previous file with comments | « components/history/core/browser/url_utils.cc ('k') | no next file » | no next file with comments »