Issue 1179943005: Make RaisedButton support being disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179943005: Make RaisedButton support being disabled. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
jackson

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make RaisedButton support being disabled. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/6cacdb4c5a34badf50953b53f8bb9af8668a33c2

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -18 lines)			Patch
M	sky/examples/widgets/container.dart	View	1 chunk	+13 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/theme2/colors.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/raised_button.dart	View	2 chunks	+19 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jackson

lgtm https://codereview.chromium.org/1179943005/diff/1/sky/sdk/lib/widgets/raised_button.dart File sky/sdk/lib/widgets/raised_button.dart (right): https://codereview.chromium.org/1179943005/diff/1/sky/sdk/lib/widgets/raised_button.dart#newcode51 sky/sdk/lib/widgets/raised_button.dart:51: color: theme == RaisedButtonTheme.light might want to work ...

5 years, 6 months ago (2015-06-16 00:16:01 UTC) #2

Hixie

5 years, 6 months ago (2015-06-16 00:32:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6cacdb4c5a34badf50953b53f8bb9af8668a33c2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages