Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1179943002: DevTools: history input should overwrite last history entry with user-input (Closed)

Created:
5 years, 6 months ago by lushnikov
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: history input should overwrite last history entry with user-input The history input should support the following scenario: 1. Scroll to the very end of the history input. You'll get it empty 2. Type something 3. Scroll up once, then down once Expected: the latest history entry has user input preserved. BUG=499215 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M Source/devtools/front_end/ui/HistoryInput.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pfeldman
lgtm
5 years, 6 months ago (2015-06-13 06:54:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179943002/1
5 years, 6 months ago (2015-06-15 12:34:28 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 13:29:49 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197110

Powered by Google App Engine
This is Rietveld 408576698