Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 1179933002: Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/) Reason for revert: It broke webkit_unit_tests Original issue's description: > Remove GetAttributes from the mix to avoid another virtual dispatch. > > BUG=chromium:495949, v8:4137 > LOG=n > > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175 > Cr-Commit-Position: refs/heads/master@{#28953} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:495949, v8:4137 Committed: https://crrev.com/ae639d2ad646237e2f413259a0f116845ef96440 Cr-Commit-Position: refs/heads/master@{#28958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -35 lines) Patch
M src/elements.h View 2 chunks +14 lines, -2 lines 0 comments Download
M src/elements.cc View 11 chunks +90 lines, -32 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Igor Sheludko
Created Revert of Remove GetAttributes from the mix to avoid another virtual dispatch.
5 years, 6 months ago (2015-06-11 17:25:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179933002/1
5 years, 6 months ago (2015-06-11 17:25:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 17:25:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae639d2ad646237e2f413259a0f116845ef96440 Cr-Commit-Position: refs/heads/master@{#28958}
5 years, 6 months ago (2015-06-11 17:25:43 UTC) #4
Toon Verwaest
5 years, 6 months ago (2015-06-11 20:16:53 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1182603002/ by verwaest@chromium.org.

The reason for reverting is: Reland, this didn't break anything..

Powered by Google App Engine
This is Rietveld 408576698