Issue 117993006: Run the incognito title-changing content_script extension for tests at document_end

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 117993006: Run the incognito title-changing content_script extension for tests at document_end (Closed)

Created:
6 years, 11 months ago by Peter Beverloo

Modified:
6 years, 11 months ago

Reviewers:
wjmaclean

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Run the incognito title-changing content_script extension for tests at document_end In Blink r164582 ("Don't set document.title when there is no <head>") Blink aligns the behavior of the "document.title" property with the HTML specification, and now disregards users who set the title when no <head> or <title> element exist yet. This content_script extension runs at document_start, at which time no DOM is available yet. Changing this to document_end means that the DOM is available, and it's thus able to change the page's title (the sole purpose of the extension). BUG=332106 R=wjmaclean@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243317

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/data/extensions/api_test/incognito/content_scripts/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Beverloo

6 years, 11 months ago (2014-01-07 17:31:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r243317 (presubmit successful).

Expand Messages | Collapse Messages